Skip to content

dird: fix status schedule(r) command behaviour#499

Merged
frb121 merged 1 commit intomasterfrom
dev/fbergkemper/master/s3384
May 6, 2020
Merged

dird: fix status schedule(r) command behaviour#499
frb121 merged 1 commit intomasterfrom
dev/fbergkemper/master/s3384

Conversation

@frb121
Copy link
Contributor

@frb121 frb121 commented Apr 30, 2020

This commit fixes the behaviour of the status schedule(r) command.

  • Take disabled resources into account when a job is given
  • Take disabled resources into account when a client is given
  • Take disabled resources into account when a schedule is given

@frb121 frb121 requested a review from franku April 30, 2020 12:25
@frb121 frb121 marked this pull request as draft April 30, 2020 12:38
@frb121 frb121 force-pushed the dev/fbergkemper/master/s3384 branch from a9078a5 to 8ff0f55 Compare April 30, 2020 14:11
@frb121 frb121 changed the title dird: fix status scheduler preview dird: fix status scheduler command behaviour Apr 30, 2020
@frb121 frb121 marked this pull request as ready for review April 30, 2020 14:13
@frb121 frb121 changed the title dird: fix status scheduler command behaviour dird: fix status schedule(r) command behaviour Apr 30, 2020
@frb121 frb121 force-pushed the dev/fbergkemper/master/s3384 branch from 8ff0f55 to aa31d9c Compare April 30, 2020 14:53
Copy link
Contributor

@franku franku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change two if conditionals. The other one in line 644.
Please rename schedulegiven by schedule_given_by_cmdline_args or similar.

This commit fixes the behaviour of the status schedule(r) command.

- Take disabled resources into account when a job is given
- Take disabled resources into account when a client is given
- Take disabled resources into account when a schedule is given
@frb121 frb121 force-pushed the dev/fbergkemper/master/s3384 branch from aa31d9c to d61043d Compare May 4, 2020 10:22
@frb121 frb121 merged commit 4645d7c into master May 6, 2020
@frb121 frb121 deleted the dev/fbergkemper/master/s3384 branch May 6, 2020 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants