Skip to content

dev/franku/master/dev h refactored#498

Merged
franku merged 25 commits intomasterfrom
dev/franku/master/dev-h-refactored
May 11, 2020
Merged

dev/franku/master/dev h refactored#498
franku merged 25 commits intomasterfrom
dev/franku/master/dev-h-refactored

Conversation

@franku
Copy link
Contributor

@franku franku commented Apr 28, 2020 •
edited
Loading

Refactored Device and DeviceControlRecord:

  • moved code from dev.h into separated files
  • renamed member variables to match their purpose
  • "modernized" the dynamic loader interface of device

pstorz
pstorz approved these changes Apr 30, 2020
View reviewed changes
Copy link
Member

@pstorz pstorz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the small comments this looks good.

franku added 13 commits May 6, 2020 13:03
@franku
stored: separated VolumeCatalogInfo
5f3341c
@franku
stored: separated DeviceStatusInformation
fdc3184
@franku
stored: cleanup dev.h class initialzation
b7fd157
@franku
stored: move DeviceControlRecord to a separate header file
1235c61
@franku
stored: move some status codes to wait.h
38375e6
@franku
stored: move a struct to a separate file
55fbbd4
@franku
stored: replace a dlist by std::vector
9332469 
- DeviceControlRecords attached to a Device are now stored in a std::vector
- Device is pure virtual therefore added a derived class needed for Spooling
@franku
stored: use enum class instead of integer for DeviceMode
b089aa5
@franku
stored: use enum class instead of integer for DeviceType
864ba1d
@franku
stored: use enum class instead of uint16_t for AutoXflateMode
1b9cb6d
@franku
cleanup: correct some declarations and a windows crossbuild error
efec223
@franku
sd-backends: use default constructor for doplet device
99314d7
@franku
sd-backends: use default constructor for unix file device
0caf77b
@franku franku force-pushed the dev/franku/master/dev-h-refactored branch 3 times, most recently from b8d35eb to d09d213 Compare May 7, 2020 13:31
franku added 11 commits May 7, 2020 17:55
@franku
stored: refactor backend loader code
d50e57f 
- used std::vector instead of alist
- removed or replaced Poolmem for strings
- used smartpointer for allocated memory
- renamed variables and functions more meaningful
@franku
stored: use destructor instead of Device::term()
031e39d
@franku
stored: rename device to device_resource in class Device
fc1b07a
@franku
cleanup: rename device by device_resource
fee0dbb
@franku
btape: cleanup local variables
71204c0
@franku
stored: rename device to device_resource in class DeviceControlRecord
58f7162
@franku
cleanup: rename device by device_resource
9d5b329
@franku
stored: rename device to device_resource in class ReserveContext
fec2219
@franku
stored: rename device alist to device_resource in class AutochangerRe…
f9db2bc 
…source
@franku
stored: use a base class as interface for the backends
a7cbe31
@franku
stored: rename backend device calls
9cd0ee7
@franku franku force-pushed the dev/franku/master/dev-h-refactored branch from b0d22ee to 9cd0ee7 Compare May 7, 2020 16:52
@franku
Copy link
Contributor Author

franku commented May 11, 2020

Manually checked PR build and repo tests for: 20.0.0~pre606.2b13e8318

@franku franku merged commit 3b26565 into master May 11, 2020
@franku franku deleted the dev/franku/master/dev-h-refactored branch May 11, 2020 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pstorz pstorz pstorz approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@franku @pstorz