Merged
Conversation
franku
reviewed
Apr 30, 2020
core/src/findlib/bfile.cc
Outdated
| if (bfd->flags_ & O_RDONLY) { | ||
| /* If not RDWR or WRONLY must be Read Only */ | ||
| if (!(bfd->m_flags & (O_RDWR|O_WRONLY))) { | ||
| fdatasync(bfd->fid); /* sync the file */ |
Contributor
There was a problem hiding this comment.
Suggested change
| fdatasync(bfd->fid); /* sync the file */ |
Member
There was a problem hiding this comment.
We discussed this and we agree that calling fdatasync() is not a good idea in this case.
arogge
reviewed
Apr 30, 2020
core/src/findlib/bfile.cc
Outdated
| #if defined(HAVE_POSIX_FADVISE) && defined(POSIX_FADV_DONTNEED) | ||
| if (bfd->flags_ & O_RDONLY) { | ||
| /* If not RDWR or WRONLY must be Read Only */ | ||
| if (!(bfd->m_flags & (O_RDWR|O_WRONLY))) { |
Member
There was a problem hiding this comment.
Suggested change
| if (!(bfd->m_flags & (O_RDWR|O_WRONLY))) { | |
| if (!(bfd->flags_ & (O_RDWR|O_WRONLY))) { |
Member
|
Could you please update the commit message according to https://docs.bareos.org/DeveloperGuide/gitworkflow.html#commit-message-guideline so it at least contains |
Fixes bareos#1227: Fix fadvise bug Suggested changes implemented: - bareos#496 (comment) - bareos#496 (comment)
arogge
approved these changes
May 5, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As per request in https://bugs.bareos.org/view.php?id=1227