dird: make UA tree command auditing possible#493
Merged
Conversation
b7a0b4b to
6f036bc
Compare
franku
suggested changes
Apr 24, 2020
Contributor
franku
left a comment
There was a problem hiding this comment.
Looks good. However, I suggested some changes. Please see my comments.
Please note, any commit should compile successful on its own if it can be easily achieved.
This makes git bisect much more straightforward if someone wants to find a siltent bug someday.
cadc43e to
00a7702
Compare
1. Introduce a new boolean named audit_event in the struct cmdstruct of the TreeContext to mark commands which require auditing. 2. Introduce a condition in the UserSelectFilesFromTree function to call LogAuditEventCmdline if the given command wants an audit event.
To be able to send "custom" UA auditing messages, the method LogAuditEventInfoMsg(const char* fmt, ...) is introduced to the UaContext class.
00a7702 to
e9cb830
Compare
franku
approved these changes
Apr 28, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce a new boolean named audit_event in the struct cmdstruct
of the TreeContext to mark commands which require auditing.
Introduce a condition in the UserSelectFilesFromTree function to
call LogAuditEventCmdline if the given command wants an audit event.