docs: document a critical bscan limitation#460
Merged
Conversation
0e22fe3 to
e5ab069
Compare
arogge
approved these changes
Mar 25, 2020
Member
arogge
left a comment
There was a problem hiding this comment.
This is great documentation that explains the limitation in detail. I really appreciate it!
I personally like to structure ReST with one sentence per line. This helps to get reasonable diffs that show changes in content and not in the plain-text formatting. It also helps the writer to detect overly long sentences, which may lead to shorter sentences and simpler language. However, as always YMMV.
Contributor
Author
|
Any more comments? If not, I'm going to rebase the draft and open the actual PR. |
eb8bc59 to
b1b8de1
Compare
franku
approved these changes
Mar 26, 2020
Contributor
franku
left a comment
There was a problem hiding this comment.
Some minor suggestions on a PM
b1b8de1 to
c763065
Compare
c763065 to
6b0e848
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is just a draft which needs to be discussed.