Merged
Conversation
pstorz
reviewed
Mar 12, 2020
Member
pstorz
left a comment
There was a problem hiding this comment.
We have a PR for master and for 18.2, but not for 19. Is that intended?
core/src/dird/ndmp_dma_storage.cc
Outdated
| */ | ||
| if (ndma_session_commission(ndmp_sess)) { goto bail_out; } | ||
| if (ndma_session_commission(ndmp_sess)) { | ||
| Dmsg0(200, "Could not commission the ndma sessiond.\n"); |
core/src/dird/ndmp_dma_storage.cc
Outdated
|
|
||
| if (!GetRobotElementStatus(ua->jcr, store, &ndmp_sess)) { return false; } | ||
| if (!GetRobotElementStatus(ua->jcr, store, &ndmp_sess)) { | ||
| Dmsg0(200, "Could not get GetRobotElementStatus.\n"); |
Member
There was a problem hiding this comment.
I think this should be identical to the wording in line 651:
Dmsg0(200, "Could not get robot element status.\n");
| */ | ||
| if (!NdmpUpdateStorageMappings(ua, store)) { return drives; } | ||
| if (!NdmpUpdateStorageMappings(ua, store)) { | ||
| Dmsg0(200, "NdmpUpdateStorageMappings failed\n"); |
Member
There was a problem hiding this comment.
Maybe the Dmsg should contain a prefix of "NdmpGetNumSlots:" and "NdmpGetNumDrives:" here and lin line 692
Contributor
Author
There was a problem hiding this comment.
Dmsg0 prints out FILE and LINE
4b92870 to
0f2b03c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.