Conversation
arogge
requested changes
Mar 2, 2020
Member
arogge
left a comment
There was a problem hiding this comment.
Some minor improvements in the C++ code possible, testrunner needs more explanation. What is tested here? When will it fail?
core/src/dird/ua_prune.cc
Outdated
Comment on lines
+888
to
+889
| int NumJobsToBePruned = 0; | ||
| utime_t now, VolRetention; |
Member
There was a problem hiding this comment.
this declaration can be deferred, too
Comment on lines
+218
to
+221
| When performing the always incremental scheme, the jobs are **never** pruned | ||
| by the volume pruning mechanism. The jobs are pruned from the volumes after | ||
| they have been successfully consolidated, so that the volume pruning | ||
| mechanism should **not trigger at all**. |
Member
There was a problem hiding this comment.
Doesn't that imply that the volume itself will never be pruned?
Comment on lines
+2
to
+6
| # | ||
| # Run a simple backup | ||
| # then restore it. | ||
| # |
Member
There was a problem hiding this comment.
I don't really understand what this test does, and this comment doesn't describe it.
The pruning code now prints information about what jobids are pruned during volume pruning. Before, this information was not visible.
This system tests configures a very short volume retention and checks if the volume pruning is executed as expected.
Always incremental: when using relatively short values for "volume retention" in the pools, backup jobs can be pruned prematurely. This commit adds a warning and an explanation.
Co-Authored-By: Andreas Rogge <andreas.rogge@bareos.com>
ab08312 to
79e04c6
Compare
arogge
reviewed
Jun 25, 2020
|
|
||
| if (!VolumeIsNowEmtpy) { | ||
| Jmsg(ua->jcr, M_INFO, 0, | ||
| _("Volume \"%s\" still contains jobs after pruning.\n")); |
Member
There was a problem hiding this comment.
How did I miss this bug?
This is btw. why we want a modern formatting library that would have detected this at compile-time...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.