Conversation
arogge
left a comment
There was a problem hiding this comment.
Thank you very much for digging into this and for contributing to our project!
We will need to test this ourselves, but the change looks reasonable and we will probably accept it.
However, as you might have noticed in the past Germans always find something to complain about: Your commit message could be improved. If you're not used to git, nevermind - it'll just do fine as it is. If you're happy to reword it, take a look at https://docs.bareos.org/master/DeveloperGuide/gitworkflow.html#commit-message-guideline
That page will explain how to format the message so it can be handled by Mantis. It also gives a rough guideline how we like out commit messages.
|
Thanks for your fix, I just verified that it works. It was a bug indeed. But as Andreas mentioned, please change your commit message. This article may help you how to do that: |
This patch for backup a VM by using VM id
Fix Ovirt Plugin "Backup a VM by using VM ID"