Skip to content

dev/franku/master/messages resource#414

Merged
franku merged 17 commits intomasterfrom
dev/franku/master/messages_resource
Feb 10, 2020
Merged

dev/franku/master/messages resource#414
franku merged 17 commits intomasterfrom
dev/franku/master/messages_resource

Conversation

@franku
Copy link
Contributor

@franku franku commented Feb 10, 2020

Combined system-/unittest to check output of the configurable message destinations.

@franku franku force-pushed the dev/franku/master/messages_resource branch from cbba9cf to 754dbd6 Compare February 10, 2020 12:50
@pstorz
Copy link
Member

pstorz commented Feb 10, 2020

I would suggest to move "tests/messages.cc" to "tests/messages_resource_test.cc"
See the names of the other files in the tests directory.

@franku franku force-pushed the dev/franku/master/messages_resource branch from 754dbd6 to 540af52 Compare February 10, 2020 17:12
pstorz
pstorz approved these changes Feb 10, 2020
View reviewed changes
Copy link
Member

@pstorz pstorz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

franku added 17 commits February 10, 2020 21:55
@franku
messages: prevent std::string from being initialized with nullptr
f107dbf 
Fixes #1184: Using syslog or an invalid message type crashes a daemon

Do not use NULL or nullptr as const string& argument for ScanTypes
in case of an invalid destination string or for the syslog message destination
@franku
tests: add messages unit test and test-config
3264abb
@franku
messages: use const char* instead of char* for message string
5a7a848
@franku
lib: move getenv_std_string function from tests to lib/util
a9a9f63
@franku
systemtests: add messages-test
6328afd
@franku
systemtests: write testrunner script for the messages test
8aaf7b2 
- call the messages unittest to distribute a message
- check if the desired files exist and contain the expected message
@franku
lib: prepare callbacks for mockup callbacks in unittests
93cef66
@franku
systemtest: add more test pattern to message test
249ca15
@franku
systemtests: add stdout and stderr as destination to messages
3800ebc
@franku
tests: evaluate REGRESS_DEBUG in messages test
ffbf368
@franku
systemtests: rename filenames used for messages output files
43e48cb 
- rename filenames
- add a environment variable for the logfile path
@franku
systemtests: add the operator and mail destination to messages test
7c34494 
- add the destinations to the messages resource
- reword the test string
@franku
tests: do not build messages unittest for client-only
a2441f3
@franku
tests: cleanup messages unittest
c0e80d4 
- renamed variables
- use only one map for the filepointers
- reordered the initialization
@franku
systemtests: cleanup and reword messages test
19aa323
@franku
tests: rename messages to messages_resource
6354b79
@franku
systemtests: rename messages-test to messages-resource
04e108a 
- this name matches the corresponding unittest
@franku franku force-pushed the dev/franku/master/messages_resource branch from 540af52 to 04e108a Compare February 10, 2020 20:55
@franku franku merged commit cf046c8 into master Feb 10, 2020
@franku franku deleted the dev/franku/master/messages_resource branch April 6, 2020 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pstorz pstorz pstorz approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@franku @pstorz