Skip to content

Increase read timeout in Proxmox plugin#2544

Merged
BareosBot merged 2 commits intobareos:masterfrom
arogge:proxmox-read-timeout
Feb 18, 2026
Merged

Increase read timeout in Proxmox plugin#2544
BareosBot merged 2 commits intobareos:masterfrom
arogge:proxmox-read-timeout

Conversation

@arogge
Copy link
Member

@arogge arogge commented Feb 18, 2026 •
edited by bruno-at-bareos
Loading

Increases the timeout when collecting the data and waiting for the
"sending archive to stdout" message from 500ms to 5 minutes.

Thank you for contributing to the Bareos Project!

Please check

  • Short description and the purpose of this PR is present above this paragraph
  • Your name is present in the AUTHORS file (optional)

If you have any questions or problems, please give a comment in the PR.

Helpful documentation and best practices

Checklist for the reviewer of the PR (will be processed by the Bareos team)

Make sure you check/merge the PR using devtools/pr-tool to have some simple automated checks run and a proper changelog record added.

General
  • Is the PR title usable as CHANGELOG entry?
  • Purpose of the PR is understood
  • Commit descriptions are understandable and well formatted
  • Required backport PRs have been created
  • Correct milestone is set
Source code quality
  • Source code changes are understandable
  • Variable and function names are meaningful
  • Code comments are correct (logically and spelling)
  • Required documentation changes are present and part of the PR

@arogge arogge added this to the 25.0.3 milestone Feb 18, 2026
@arogge arogge added bug This addresses a bug requires no backport This will not be backported subscription labels Feb 18, 2026
@arogge arogge self-assigned this Feb 18, 2026
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 18, 2026 •
edited
Loading

Caution

Review failed

The pull request is closed.

📝 Walkthrough

Walkthrough

The read_timeout used when reading lines from the log pipe in start_backup_file was increased from 500 milliseconds to 300000 milliseconds (5 minutes), extending the maximum wait for end-of-line data while processing vzdump output. No other logic or error handling was changed.

Changes

Cohort / File(s) Summary
Proxmox backup plugin
core/src/plugins/filed/python/proxmox/bareos-fd-proxmox.py		 Adjusted read_timeout passed to self.log_pipe.readlines from 500 ms to 300000 ms (5 minutes); no other logic or error handling changed.
Changelog
CHANGELOG.md		 Added entry noting the increased Proxmox plugin read timeout under "Fixed" and updated unreleased PR reference; documentation-only change.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 I sat beside the humming stream,
Watching lines join the backup dream.
Timeout grew from quick to kind,
Five calm minutes for logs to find.
I nibble, smile, and hop in time. 🥕

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title 'Increase read timeout in Proxmox plugin' clearly and concisely summarizes the main change, which is increasing a read timeout parameter in the Proxmox plugin.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Description check ✅ Passed The pull request description includes a clear summary of changes and properly completes the provided template with relevant checkboxes marked.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Tip

Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord.

Comment @coderabbitai help to get the list of available commands and usage tips.

@arogge arogge added requires backport to 25 and removed requires no backport This will not be backported labels Feb 18, 2026
@arogge arogge force-pushed the proxmox-read-timeout branch from 7f7832b to e727153 Compare February 18, 2026 10:24
@arogge arogge mentioned this pull request Feb 18, 2026
Merged
7 tasks
@arogge arogge removed this from the 25.0.3 milestone Feb 18, 2026
@bruno-at-bareos bruno-at-bareos added this to the 26.0.0 milestone Feb 18, 2026
@arogge
proxmox-plugin: increase read timeout
08222f1 
Increases the timeout when collecting the data and waiting for the
"sending archive to stdout" message from 500ms to 5 minutes.
@arogge arogge force-pushed the proxmox-read-timeout branch from e727153 to 08222f1 Compare February 18, 2026 10:35
bruno-at-bareos
bruno-at-bareos approved these changes Feb 18, 2026
View reviewed changes
Copy link
Contributor

@bruno-at-bareos bruno-at-bareos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent. Will be a nice improvement.

@BareosBot BareosBot merged commit a3ab898 into bareos:master Feb 18, 2026
0 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bruno-at-bareos bruno-at-bareos bruno-at-bareos approved these changes

Assignees

@arogge arogge

Labels

bug This addresses a bug requires backport to 25 subscription

Projects

None yet

Milestone

26.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@arogge @bruno-at-bareos @BareosBot