bareos-fd-mariabackup: ignore invalid utf8 on decode()#2527
Merged
BareosBot merged 2 commits intobareos:masterfrom Feb 9, 2026
Merged
bareos-fd-mariabackup: ignore invalid utf8 on decode()#2527BareosBot merged 2 commits intobareos:masterfrom
BareosBot merged 2 commits intobareos:masterfrom
Conversation
Contributor
|
Thanks for the PR. Did you check why mariadb outputs non-utf8 data for you ? Does it run with a different locale ? |
Contributor
Author
|
The databases are utf8mb4 and utf8mb3 containing icinga2 check results and icingaweb2 settings. I suspect some perfdata output from icinga2/nagios plugins might be not properly utf8 encoded, but I didn't debug any further. If needed I could add some debug lines to save the output to a file if decoding goes wrong. |
sebsura
approved these changes
Feb 4, 2026
Contributor
|
Feel free to add yourself to the |
9f6e990 to
53c3daf
Compare
53c3daf to
1bd2416
Compare
15 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for contributing to the Bareos Project!
From time to time my mariadb backups (11.8.5 in my case) failed with
I guess it's best to just ignore non-decodeable data as it's probably irrelevant for extracting the LSN.
Please check
If you have any questions or problems, please give a comment in the PR.
Helpful documentation and best practices
Checklist for the reviewer of the PR (will be processed by the Bareos team)
Make sure you check/merge the PR using
devtools/pr-toolto have some simple automated checks run and a proper changelog record added.General
Required backport PRs have been createdSource code quality