core/filed: fix spurious wakeups race condition in filed.#2513
Merged
BareosBot merged 2 commits intobareos:bareos-25from Jan 22, 2026
Merged
Conversation
811cf9a to
3c01411
Compare
This patch fixes a race condition in filed due to spurious wakeups. Without this fix, a thread waiting on the compute_fin condition variable may wake up spuriously immediately after the lock counter is decremented but before notify_one() is called. In that window, the thread can bail out prematurely, which later leads to a segmentation fault when the other thread calls notify_one(). (cherry picked from commit 2fcf4c2)
7c26da8 to
b5d5ff4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of PR #2508 to bareos-25
Checklist for the reviewer of the PR (will be processed by the Bareos team)
Make sure you check/merge the PR using
devtools/pr-toolto have some simple automated checks run and a proper changelog record added.General
Source code quality (if there were changes to the original PR)
Backport quality