systemtests: tune for execution on Windows#2501
Merged
BareosBot merged 4 commits intobareos:masterfrom Jan 13, 2026
Merged
Conversation
pstorz
approved these changes
Jan 12, 2026
Member
pstorz
left a comment
There was a problem hiding this comment.
Looks goode. Approved. The only question I have is why we do not need the debian postgres detection anymore.
| PATH="@CYGWIN_RUNTIME_OUTPUT_DIRECTORY@:$PATH" | ||
| fi | ||
|
|
||
| # Real postgres binaries are hidden on debian, instead there are wrappers |
Member
There was a problem hiding this comment.
Nice that it is not needed anymore, but why?
Member
Author
There was a problem hiding this comment.
Line 173 sets POSTGRES_BIN_PATH and POSTGRES_BINARY_DIR is never used.
I guess this was already refactored but this part was overlooked.
For the Windows variant, we can just assume that PostgreSQL's bin-directory is already in the path.
This was referenced Jan 13, 2026
this is no more needed as multi-configuration builds are not supported anymore. This hurt performance on windows where (for some reason) calling `dirname` takes a pretty long time.
this removes calls to things not built into the shell from environment to save time: * determining the PostgreSQL path is not needed anymore * `cygpath` will now be called in CMake instead of running it again and again.
only set the variables we need to determine with dirname when they are actually used (i.e. in the start case).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The systemtests have some performance issues on Windows machines. Some of these can be worked around pretty easily, so this PR tries to improve things.
Mainly running anything not built into the shell will take a lot longer on Windows than it does on Unix. Thus optimizing shell code that runs very often during testing seems to improve things a lot.
Please check
If you have any questions or problems, please give a comment in the PR.
Helpful documentation and best practices
Checklist for the reviewer of the PR (will be processed by the Bareos team)
Make sure you check/merge the PR using
devtools/pr-toolto have some simple automated checks run and a proper changelog record added.General
Source code quality