Skip to content

barri: remove unnecessary quotes in version text#2498

Merged
BareosBot merged 4 commits intobareos:masterfrom
sebsura:dev/ssura/master/fix-barri-quotes
Jan 22, 2026
Merged

barri: remove unnecessary quotes in version text#2498
BareosBot merged 4 commits intobareos:masterfrom
sebsura:dev/ssura/master/fix-barri-quotes

Conversation

@sebsura
Copy link
Contributor

@sebsura sebsura commented Jan 9, 2026

Thank you for contributing to the Bareos Project!

cmake is sometimes weird. Apparently using a="${b}" inside a target_compile_definitions adds actual quotes, where as "a=${b}" does not.

Please check

  • Short description and the purpose of this PR is present above this paragraph
  • Your name is present in the AUTHORS file (optional)

If you have any questions or problems, please give a comment in the PR.

Helpful documentation and best practices

Checklist for the reviewer of the PR (will be processed by the Bareos team)

Make sure you check/merge the PR using devtools/pr-tool to have some simple automated checks run and a proper changelog record added.

General
  • Is the PR title usable as CHANGELOG entry?
  • Purpose of the PR is understood
  • Commit descriptions are understandable and well formatted
  • Required backport PRs have been created
  • Correct milestone is set
Source code quality
  • Source code changes are understandable
  • Variable and function names are meaningful
  • Code comments are correct (logically and spelling)
  • Required documentation changes are present and part of the PR

@sebsura sebsura requested a review from pstorz January 9, 2026 07:06
@sebsura sebsura linked an issue Jan 9, 2026 that may be closed by this pull request
@pstorz pstorz added this to the 26.0.0 milestone Jan 13, 2026
Copy link
Member

@pstorz pstorz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@sebsura sebsura force-pushed the dev/ssura/master/fix-barri-quotes branch from 61d3c70 to 3affa28 Compare January 21, 2026 08:03
@BareosBot BareosBot merged commit e759709 into bareos:master Jan 22, 2026
1 check was pending
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

barri-cli: remove quotes from version info

4 participants