systemtests: autochanger add testrunner-restore-non-present-volume#2476
Merged
BareosBot merged 18 commits intobareos:masterfrom Jan 20, 2026
Merged
Conversation
sebsura
requested changes
Dec 9, 2025
Contributor
sebsura
left a comment
There was a problem hiding this comment.
I didnt review everything, i just looked at some parts.
f3dfe1a to
a5db6db
Compare
Contributor
Author
|
@sebsura it look like I addressed all of yours remarks. |
sebsura
requested changes
Jan 8, 2026
systemtests/tests/autochanger/testrunner-restore-non-present-volume
Outdated
Show resolved
Hide resolved
cc9ce50 to
f085d95
Compare
sebsura
approved these changes
Jan 14, 2026
Contributor
sebsura
left a comment
There was a problem hiding this comment.
Thanks for the great work!
7 tasks
- set Testname so the variable exist - add mt cpio detection: mt cpio doesn't work with status on no tape loaded.
- add license - use log_home for logging action - tmp is used for bconsole action - follow shellcheck recommendation - add release all drives - use redirection and simplify extraction limiting subshell with awk Signed-off-by: Bruno Friedmann <bruno.friedmann@bareos.com>
- autochanger test: add test restore with non present media to track warnings and reading issue after mount request
- describe completely what we expect to find and what's not. - make restore concurrent possible by changing the Maximum Concurrent Jobs in RestoreFiles.conf.in - update copyright year Signed-off-by: Bruno Friedmann <bruno.friedmann@bareos.com>
- simplify loop by using one line of echo - update copyright year
Co-authored-by: Sebastian Sura <124262655+sebsura@users.noreply.github.com>
- restores happen in tmp - list_of_jobis stay in tmp as shared between tests
Signed-off-by: Bruno Friedmann <bruno.friedmann@bareos.com>
use correct command for restore jobid without select all, this make the restore more reliable in terms of expected results. Signed-off-by: Bruno Friedmann <bruno.friedmann@bareos.com>
f085d95 to
c4adcb5
Compare
sebsura
requested changes
Jan 15, 2026
Signed-off-by: Bruno Friedmann <bruno.friedmann@bareos.com>
sebsura
approved these changes
Jan 20, 2026
Signed-off-by: Bruno Friedmann <bruno.friedmann@bareos.com>
a2fa9c3 to
b36952b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims to introduce a new systemtests for autochanger.
We want to test a restore with a non present volume (like exported tapes).
We review and improve also the existing testrunner:
Please check
If you have any questions or problems, please give a comment in the PR.
Helpful documentation and best practices
Checklist for the reviewer of the PR (will be processed by the Bareos team)
Make sure you check/merge the PR using
devtools/pr-toolto have some simple automated checks run and a proper changelog record added.General
Tests