Skip to content

dirconfig: add subscription setting with comment#2468

Merged
BareosBot merged 2 commits intobareos:masterfrom
pstorz:dev/pstorz/master/add-subscriptions-setting-to-director
Dec 4, 2025
Merged

dirconfig: add subscription setting with comment#2468
BareosBot merged 2 commits intobareos:masterfrom
pstorz:dev/pstorz/master/add-subscriptions-setting-to-director

Conversation

@pstorz
Copy link
Member

@pstorz pstorz commented Dec 2, 2025

This PR add as commented the subscription parameter in default config, this will help users when they want/need to set it up.

Please check

  • Short description and the purpose of this PR is present above this paragraph
  • Your name is present in the AUTHORS file (optional)

If you have any questions or problems, please give a comment in the PR.

Helpful documentation and best practices

Checklist for the reviewer of the PR (will be processed by the Bareos team)

Make sure you check/merge the PR using devtools/pr-tool to have some simple automated checks run and a proper changelog record added.

General
  • Is the PR title usable as CHANGELOG entry?
  • Purpose of the PR is understood
  • Commit descriptions are understandable and well formatted
  • Required backport PRs have been created
  • Correct milestone is set
Source code quality
  • Source code changes are understandable
  • Variable and function names are meaningful
  • Code comments are correct (logically and spelling)
  • Required documentation changes are present and part of the PR
Tests

No changes are made in already existing systemtests.

@pstorz pstorz added the documentation This PR changes only documentation label Dec 2, 2025
@pstorz pstorz added this to the 25.0.1 milestone Dec 2, 2025
@bruno-at-bareos bruno-at-bareos self-requested a review December 3, 2025 14:30
@bruno-at-bareos bruno-at-bareos removed the documentation This PR changes only documentation label Dec 3, 2025
Copy link
Contributor

@bruno-at-bareos bruno-at-bareos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Globally should just go strait forward, but it was not build, so I would build it one time, just to prove we got the parameter in packaged configurations.
I've removed the label documentation.

Copy link
Contributor

@bruno-at-bareos bruno-at-bareos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested build packages -> ok
Backport created

@BareosBot BareosBot force-pushed the dev/pstorz/master/add-subscriptions-setting-to-director branch from 2786934 to 429b131 Compare December 4, 2025 10:41
@BareosBot BareosBot merged commit c1fc314 into bareos:master Dec 4, 2025
@pstorz pstorz modified the milestones: 25.0.1, 26.0.0 Dec 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants