Skip to content

VMware Plugin: Fix NVRAM backup when datacenter is not in root folder#2461

Merged
BareosBot merged 3 commits intobareos:masterfrom
sduehr:dev/sduehr/master/fix-vmware-issue-2410
Dec 9, 2025
Merged

VMware Plugin: Fix NVRAM backup when datacenter is not in root folder#2461
BareosBot merged 3 commits intobareos:masterfrom
sduehr:dev/sduehr/master/fix-vmware-issue-2410

Conversation

@sduehr
Copy link
Member

@sduehr sduehr commented Nov 27, 2025

In most cases, the DC (datacenter) object is located in the root folder, but it could also be inside a folder. In that case the plugin failed to backup the NVRAM files and on restore it didn't find the DC. Both cases are fixed now.

Please check

  • Short description and the purpose of this PR is present above this paragraph
  • Your name is present in the AUTHORS file (optional)

If you have any questions or problems, please give a comment in the PR.

Helpful documentation and best practices

Checklist for the reviewer of the PR (will be processed by the Bareos team)

Make sure you check/merge the PR using devtools/pr-tool to have some simple automated checks run and a proper changelog record added.

General
  • Is the PR title usable as CHANGELOG entry?
  • Purpose of the PR is understood
  • Commit descriptions are understandable and well formatted
  • Required backport PRs have been created
  • Correct milestone is set
Source code quality
  • Source code changes are understandable
  • Variable and function names are meaningful
  • Code comments are correct (logically and spelling)
  • Required documentation changes are present and part of the PR

@sduehr sduehr added the bug This addresses a bug label Nov 27, 2025
@sduehr sduehr linked an issue Nov 27, 2025 that may be closed by this pull request
@arogge arogge requested a review from pstorz December 8, 2025 10:24
@pstorz pstorz added this to the 25.0.2 milestone Dec 8, 2025
Copy link
Member

@pstorz pstorz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

sduehr and others added 3 commits December 9, 2025 11:14
In most cases, the DC (datacenter) object is located in the root folder,
but it could also be inside a folder. In that case the plugin failed to
backup the NVRAM files and on restore it didn't find the DC. Both cases
are fixed now.
@BareosBot BareosBot force-pushed the dev/sduehr/master/fix-vmware-issue-2410 branch from 1e697ea to 74a5900 Compare December 9, 2025 11:14
@BareosBot BareosBot merged commit 967251a into bareos:master Dec 9, 2025
@sduehr sduehr modified the milestones: 25.0.2, 26.0.0 Dec 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug This addresses a bug requires backport to 25

Projects

None yet

Development

Successfully merging this pull request may close these issues.

404 error when backup VM using the plugin "bareos-vmware-plugin"

4 participants