Skip to content

packaging: make contrib-tools use defaultsconfig#2445

Merged
BareosBot merged 2 commits intobareos:masterfrom
bruno-at-bareos:dev/bruno/master/fix-contrib-tools-defaultsconfig
Nov 21, 2025
Merged

packaging: make contrib-tools use defaultsconfig#2445
BareosBot merged 2 commits intobareos:masterfrom
bruno-at-bareos:dev/bruno/master/fix-contrib-tools-defaultsconfig

Conversation

@bruno-at-bareos
Copy link
Contributor

@bruno-at-bareos bruno-at-bareos commented Nov 18, 2025

  • make contrib-tools package using the new defaultsconfig directory
    spec and debian
  • install configtemplatedir as dir so its belong to bareos-common

Fix bareos/internal#496

Please check

  • Short description and the purpose of this PR is present above this paragraph
  • Your name is present in the AUTHORS file (optional)

If you have any questions or problems, please give a comment in the PR.

Helpful documentation and best practices

Checklist for the reviewer of the PR (will be processed by the Bareos team)

Make sure you check/merge the PR using devtools/pr-tool to have some simple automated checks run and a proper changelog record added.

General
  • Is the PR title usable as CHANGELOG entry?
  • Purpose of the PR is understood
  • Commit descriptions are understandable and well formatted
  • Required backport PRs have been created
  • Correct milestone is set
Source code quality
  • Source code changes are understandable
  • Variable and function names are meaningful
  • Code comments are correct (logically and spelling)
  • Required documentation changes are present and part of the PR

@bruno-at-bareos bruno-at-bareos added this to the 25.0.0 milestone Nov 18, 2025
@bruno-at-bareos bruno-at-bareos added bugfix requires no backport This will not be backported labels Nov 18, 2025
@bruno-at-bareos bruno-at-bareos self-assigned this Nov 18, 2025
@bruno-at-bareos
Copy link
Contributor Author

@arogge I was not yet sure what about

%config(noreplace) %{_sysconfdir}/%{name}/mtx-changer.conf

Shouldn't be it treated like bconsole (but would need an extension of bareos-config which I wouldn't see happening right before the release

@bruno-at-bareos bruno-at-bareos force-pushed the dev/bruno/master/fix-contrib-tools-defaultsconfig branch from aae1fab to 13cd74d Compare November 20, 2025 12:09
Copy link
Member

@arogge arogge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty straightforward. Thank you very much!

bruno-at-bareos and others added 2 commits November 21, 2025 15:09
- make contrib-tools package using the new defaultconfigs directory
  spec and debian
- install configtemplatedir as dir so its belong to bareos-common
- use BareosInstallConfigFiles cmake for install

Fix bareos/internal#496

Signed-off-by: Bruno Friedmann <bruno.friedmann@bareos.com>
@BareosBot BareosBot force-pushed the dev/bruno/master/fix-contrib-tools-defaultsconfig branch from dd18e4a to ddeed78 Compare November 21, 2025 15:09
@BareosBot BareosBot merged commit 2cf9632 into bareos:master Nov 21, 2025
@bruno-at-bareos bruno-at-bareos deleted the dev/bruno/master/fix-contrib-tools-defaultsconfig branch November 26, 2025 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

requires no backport This will not be backported

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants