Merged
Conversation
arogge
commented
Nov 19, 2025
Comment on lines
+55
to
+66
| WHEN f.filesettext ILIKE '%{%{%meta%=%' THEN NULL | ||
| WHEN f.filesettext ILIKE '%{%{%Plugin%=%mssqlvdi:%' THEN NULL | ||
| WHEN f.filesettext ILIKE '%{%{%Plugin%=%python%:module_name=bareos-fd-mariabackup%' THEN NULL | ||
| WHEN f.filesettext ILIKE '%{%{%Plugin%=%python%:module_name=bareos-fd-percona%' THEN NULL | ||
| WHEN f.filesettext ILIKE '%{%{%Plugin%=%python%:module_name=bareos-fd-postgres%' THEN NULL | ||
| WHEN f.filesettext ILIKE '%{%{%Plugin%=%python%:module_name=bareos-fd-ldap%' THEN NULL | ||
| WHEN f.filesettext ILIKE '%{%{%Plugin%=%python%:module_name=bareos-fd-vmware%' THEN NULL | ||
| WHEN f.filesettext ILIKE '%{%{%Plugin%=%python%:module_name=bareos-fd-ovirt%' THEN NULL | ||
| WHEN f.filesettext ILIKE '%{%{%Plugin%=%python%:module_name=bareos-fd-libcloud%' THEN NULL | ||
| WHEN f.filesettext ILIKE '%{%{%Plugin%=%python%:module_name=bareos-fd-qumulo%' THEN NULL | ||
| WHEN f.filesettext ILIKE '%{%{%File%=%' THEN NULL | ||
| WHEN f.filesettext ILIKE '%{%{%File%=%Plugin%=%' OR f.filesettext ILIKE '%{%{%Plugin%=%File%=%' THEN |
Member
Author
There was a problem hiding this comment.
this is missing barri, proxmox and hyper-v
77c1329 to
dd507e8
Compare
bruno-at-bareos
previously requested changes
Nov 20, 2025
Contributor
bruno-at-bareos
left a comment
There was a problem hiding this comment.
We might be interested to also test ndmp classification so we will have a 100% coverage by tests.
dd507e8 to
1a8d33b
Compare
Requested change was applied
these used two views in the database previously. As it turned out, changing these requires a schema upgrade. As this is largely unfeasible, we use a WITH-clause in the query that declares the same relations the views have. This removes the need for the views in the database and thus allows to change the underlying queries without a schema change.
* remove subscriptions views from sql create script * drop subscription views in update script
add detection of new plugins: * proxmox * barri * hyper-v
Instead of jobbytes (which is the compressed size) we use bytesread where applicable (i.e. everything that is not NDMP) to get the real size of the front-end data that has been backed up.
add new plugins to the case for the fileset detailed view for unclassified content, as they are now classified.
17dd969 to
ff8b21d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bytesread(uncompressed value) instead ofjobbytes(compressed value) to determine the amount of data backed upPlease check
If you have any questions or problems, please give a comment in the PR.
Helpful documentation and best practices
Checklist for the reviewer of the PR (will be processed by the Bareos team)
Make sure you check/merge the PR using
devtools/pr-toolto have some simple automated checks run and a proper changelog record added.General
Source code quality
Tests