debugedit: fix messing with mtime#2429
Merged
BareosBot merged 2 commits intobareos:masterfrom Nov 24, 2025
Merged
Conversation
Changing the mtime of a library _after_ the .so symlinks were created messes with cmakes internal logic. In those cases cmake will decide to relink the library itself, meaning that everytime you execute a build, all libraries (and all targets depending on them) will get relinked. This is not a big issue on debug builds, but it takes a long time when building release builds with lto. This commit fixes this by using a script that restores the mtime after debugedit messed with it.
20c9323 to
134d40c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changing the mtime of a library after the .so symlinks were created messes with cmakes internal logic. In those cases cmake will decide to relink the library itself, meaning that everytime you execute a build, all libraries (and all targets depending on them) will get relinked.
This is not a big issue on debug builds, but it takes a long time when building release builds with lto.
This commit fixes this by using a script that restores the mtime after debugedit messed with it.
Thank you for contributing to the Bareos Project!
Please check
If you have any questions or problems, please give a comment in the PR.
Helpful documentation and best practices
Checklist for the reviewer of the PR (will be processed by the Bareos team)
Make sure you check/merge the PR using
devtools/pr-toolto have some simple automated checks run and a proper changelog record added.General
Required backport PRs have been createdSource code quality