cmake: fix traymonitor startup on windows#2423
Merged
BareosBot merged 2 commits intobareos:masterfrom Nov 6, 2025
Merged
Conversation
When we changed how we use vcpkg (-> manifest mode) we did not update the windows installer to use the new paths. To prevent problems in the future we now take everything (except for the openssl executable) directly from the cmake binary directory. This is possible because qtdeploy moves everything needed by qt to that directory. In the future we should look into qt cmake support which would do this in addition to other things automatically.
7 tasks
Contributor
Author
|
backport to 23 is not necessary as 23 is cross-only. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When we changed how we use vcpkg (-> manifest mode) we did not update the windows installer to use the new paths.
To prevent problems in the future we now take everything (except for the openssl executable) directly from the cmake binary directory.
This is possible because qtdeploy moves everything needed by qt to that directory. In the future we should look into qt cmake support which would do this in addition to other things automatically.
Thank you for contributing to the Bareos Project!
Please check
If you have any questions or problems, please give a comment in the PR.
Helpful documentation and best practices
Checklist for the reviewer of the PR (will be processed by the Bareos team)
Make sure you check/merge the PR using
devtools/pr-toolto have some simple automated checks run and a proper changelog record added.General
Source code quality