debian: remove dbc_debug to avoid username/password leakage#2417
Merged
BareosBot merged 4 commits intobareos:masterfrom Oct 30, 2025
Merged
Conversation
2ce5a31 to
309f489
Compare
309f489 to
b914b65
Compare
joergsteffens
requested changes
Oct 30, 2025
Member
joergsteffens
left a comment
There was a problem hiding this comment.
Well done. However, bareos-check-source did complain, so I added a commit which reformats the code. Also I've a small suggestion for the doc. Once you approve this, it can be merged.
joergsteffens
approved these changes
Oct 30, 2025
Fix bareos/internal#467 The way upstream script are using this variable, doesn't care about the value but only the variable existence. Added documentation notes about debug output with `export dbc_debug=1`. Signed-off-by: Bruno Friedmann <bruno.friedmann@bareos.com>
Co-authored-by: Jörg Steffens <joerg.steffens@bareos.com>
8054aeb to
a976468
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims to set dbc_debug to 0
so it won't show database connections details to terminal
and in apt logs
Fix bareos/internal#467
Thank you for contributing to the Bareos Project!
Please check
If you have any questions or problems, please give a comment in the PR.
Helpful documentation and best practices
Checklist for the reviewer of the PR (will be processed by the Bareos team)
Make sure you check/merge the PR using
devtools/pr-toolto have some simple automated checks run and a proper changelog record added.General
Source code quality