Skip to content

plugin: postgresql do testing with wal compress on#2408

Merged
BareosBot merged 4 commits intobareos:masterfrom
bruno-at-bareos:dev/bruno/fix-plugin-postgresql-compressed-wal
Oct 31, 2025
Merged

plugin: postgresql do testing with wal compress on#2408
BareosBot merged 4 commits intobareos:masterfrom
bruno-at-bareos:dev/bruno/fix-plugin-postgresql-compressed-wal

Conversation

@bruno-at-bareos
Copy link
Contributor

@bruno-at-bareos bruno-at-bareos commented Oct 23, 2025

We added wal compression during incremental backup so we prove
support of this PG feature.

"on" is used on PG_VERSION < 15 and "lz4" otherwise

related issue #2405

It might be interesting to backport the changes to 24, so systemtests will be easier to maintain.

Thank you for contributing to the Bareos Project!

Please check

  • Short description and the purpose of this PR is present above this paragraph
  • Your name is present in the AUTHORS file (optional)

If you have any questions or problems, please give a comment in the PR.

Helpful documentation and best practices

Checklist for the reviewer of the PR (will be processed by the Bareos team)

Make sure you check/merge the PR using devtools/pr-tool to have some simple automated checks run and a proper changelog record added.

General
  • Is the PR title usable as CHANGELOG entry?
  • Purpose of the PR is understood
  • Commit descriptions are understandable and well formatted
  • Required backport PRs have been created
  • Correct milestone is set
Source code quality
  • Source code changes are understandable
  • Variable and function names are meaningful
  • Code comments are correct (logically and spelling)
  • Required documentation changes are present and part of the PR
Tests
  • Decision taken that a test is required (if not, then remove this paragraph)
  • The choice of the type of test (unit test or systemtest) is reasonable
  • Testname matches exactly what is being tested
  • On a fail, output of the test leads quickly to the origin of the fault

@bruno-at-bareos bruno-at-bareos self-assigned this Oct 23, 2025
@bruno-at-bareos bruno-at-bareos linked an issue Oct 23, 2025 that may be closed by this pull request
@bruno-at-bareos bruno-at-bareos force-pushed the dev/bruno/fix-plugin-postgresql-compressed-wal branch from e7ad923 to 135cf42 Compare October 23, 2025 12:16
@arogge arogge requested a review from pstorz October 28, 2025 11:47
@pstorz pstorz force-pushed the dev/bruno/fix-plugin-postgresql-compressed-wal branch from 135cf42 to b02b3c0 Compare October 30, 2025 07:46
Copy link
Member

@pstorz pstorz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see comments

@bruno-at-bareos bruno-at-bareos force-pushed the dev/bruno/fix-plugin-postgresql-compressed-wal branch from b02b3c0 to 60982b8 Compare October 30, 2025 08:17
@bruno-at-bareos
Copy link
Contributor Author

Thanks a lot for the review and suggestion, I've rebased my branch with the last master changes, so I included your wording in.

Ready for final review once rebuilded

@bruno-at-bareos bruno-at-bareos force-pushed the dev/bruno/fix-plugin-postgresql-compressed-wal branch from f4568dc to 9937c41 Compare October 30, 2025 13:12
@bruno-at-bareos bruno-at-bareos added this to the 25.0.0 milestone Oct 30, 2025
bruno-at-bareos and others added 3 commits October 31, 2025 10:25
We added wal compression during incremental backup to prove
support of this PG feature.

"on" is used on PG_VERSION < 15 and "lz4" otherwise

related issue bareos#2405

Signed-off-by: Bruno Friedmann <bruno.friedmann@bareos.com>
Co-authored-by: Philipp Storz <philipp.storz@bareos.com>
@sebsura sebsura force-pushed the dev/bruno/fix-plugin-postgresql-compressed-wal branch from 65e8f85 to d6ce826 Compare October 31, 2025 09:27
Copy link
Member

@pstorz pstorz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@BareosBot BareosBot merged commit d096851 into bareos:master Oct 31, 2025
1 check was pending
@bruno-at-bareos bruno-at-bareos deleted the dev/bruno/fix-plugin-postgresql-compressed-wal branch November 26, 2025 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bareos backup crashes when wal compression is active

4 participants