Skip to content

debian: Do not make dbconfig sql files executable#2404

Merged
BareosBot merged 3 commits intobareos:masterfrom
AlexanderS:fix-executable-sql
Oct 23, 2025
Merged

debian: Do not make dbconfig sql files executable#2404
BareosBot merged 3 commits intobareos:masterfrom
AlexanderS:fix-executable-sql

Conversation

@AlexanderS
Copy link
Contributor

@AlexanderS AlexanderS commented Oct 22, 2025

upgrade-dbadmin/psql/2170 is a raw SQL file and should not be marked as executable.

Thank you for contributing to the Bareos Project!

Please check

  • Short description and the purpose of this PR is present above this paragraph
  • Your name is present in the AUTHORS file (optional)

If you have any questions or problems, please give a comment in the PR.

Helpful documentation and best practices

Checklist for the reviewer of the PR (will be processed by the Bareos team)

Make sure you check/merge the PR using devtools/pr-tool to have some simple automated checks run and a proper changelog record added.

General
  • Is the PR title usable as CHANGELOG entry?
  • Purpose of the PR is understood
  • Commit descriptions are understandable and well formatted
  • Required backport PRs have been created
  • Correct milestone is set
Source code quality
  • Source code changes are understandable
  • Variable and function names are meaningful
  • Code comments are correct (logically and spelling)
  • Required documentation changes are present and part of the PR

@sebsura sebsura requested a review from joergsteffens October 23, 2025 09:38
@joergsteffens joergsteffens self-assigned this Oct 23, 2025
Copy link
Member

@joergsteffens joergsteffens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Surely, you're right about that. i just adapt the copyright year of this file (otherwise the auto-checks fails).
Thank you for this improvement.

@joergsteffens joergsteffens added the requires no backport This will not be backported label Oct 23, 2025
@joergsteffens joergsteffens added this to the 25.0.0 milestone Oct 23, 2025
AlexanderS and others added 3 commits October 23, 2025 15:31
upgrade-dbadmin/psql/2170 is a raw SQL file and should not be marked as
executable.
@BareosBot BareosBot merged commit ad371a2 into bareos:master Oct 23, 2025
@AlexanderS AlexanderS deleted the fix-executable-sql branch October 23, 2025 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

requires no backport This will not be backported

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants