Skip to content

Fix some spelling issues#2403

Merged
BareosBot merged 5 commits intobareos:masterfrom
AlexanderS:fix-spelling
Oct 30, 2025
Merged

Fix some spelling issues#2403
BareosBot merged 5 commits intobareos:masterfrom
AlexanderS:fix-spelling

Conversation

@AlexanderS
Copy link
Contributor

@AlexanderS AlexanderS commented Oct 22, 2025 •
edited by sebsura
Loading

Thank you for contributing to the Bareos Project!

This fixes some small spelling issues:

  • occured -> occurred
  • Contructor -> Constructor
  • Unkown -> Unknown
  • attemp -> attempt

Please check

  • Short description and the purpose of this PR is present above this paragraph
  • Your name is present in the AUTHORS file (optional)

If you have any questions or problems, please give a comment in the PR.

Helpful documentation and best practices

Checklist for the reviewer of the PR (will be processed by the Bareos team)

Make sure you check/merge the PR using devtools/pr-tool to have some simple automated checks run and a proper changelog record added.

General
  • Is the PR title usable as CHANGELOG entry?
  • Purpose of the PR is understood
  • Commit descriptions are understandable and well formatted
    Required backport PRs have been created
  • Correct milestone is set
Source code quality
  • Source code changes are understandable
  • Variable and function names are meaningful
  • Code comments are correct (logically and spelling)
  • Required documentation changes are present and part of the PR

@pstorz pstorz added the nobuild label Oct 23, 2025
pstorz
pstorz previously requested changes Oct 23, 2025
View reviewed changes
Copy link
Member

@pstorz pstorz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello,

than you very much for your PR.

Could you please remove the changes in apexchart.js and Parser.php, as these
are files from other projects that we only consume.

The original project would be the right place to suggest these changes.

Thanks you very much!

@pstorz pstorz self-assigned this Oct 23, 2025
@AlexanderS
Copy link
Contributor Author

AlexanderS commented Oct 23, 2025

Could you please remove the changes in apexchart.js and Parser.php, as these are files from other projects that we only consume.

Done.

sebsura
sebsura approved these changes Oct 29, 2025
View reviewed changes
Copy link
Contributor

@sebsura sebsura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your work!

@sebsura sebsura added requires no backport This will not be backported and removed nobuild labels Oct 29, 2025
@sebsura sebsura added this to the 25.0.0 milestone Oct 29, 2025
@sebsura sebsura dismissed pstorz’s stale review October 29, 2025 14:42

I already approved it

@sebsura
Copy link
Contributor

sebsura commented Oct 30, 2025

@AlexanderS auto-merge fails because of:

[2025-10-29T15:26:22.642Z] 	Plugin 'fix copyright year' would modify 'core/src/lib/try_tls_handshake_as_a_server.cc'
[2025-10-29T15:26:22.642Z] 	Plugin 'fix copyright year' would modify 'core/src/stored/backends/unix_tape_device.cc'
[2025-10-29T15:26:22.642Z] 	Plugin 'fix copyright year' would modify 'core/src/stored/read_record.cc'

could you fix them ? You basically just need to replace the end dates of the copyright information with 2025.

@AlexanderS
Copy link
Contributor Author

AlexanderS commented Oct 30, 2025

You basically just need to replace the end dates of the copyright information with 2025.

Fixed.

@BareosBot BareosBot merged commit a63ec0c into bareos:master Oct 30, 2025
@AlexanderS AlexanderS deleted the fix-spelling branch October 30, 2025 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sebsura sebsura sebsura approved these changes

@pstorz pstorz pstorz left review comments

Assignees

@pstorz pstorz

Labels

requires no backport This will not be backported

Projects

None yet

Milestone

25.0.0

Development

Successfully merging this pull request may close these issues.

4 participants

@AlexanderS @sebsura @pstorz @BareosBot