Skip to content

don't alter configuration on ULC package updates#2399

Merged
BareosBot merged 3 commits intomasterfrom
dev/joergs/master/config-once-ulc
Oct 30, 2025
Merged

don't alter configuration on ULC package updates#2399
BareosBot merged 3 commits intomasterfrom
dev/joergs/master/config-once-ulc

Conversation

@joergsteffens
Copy link
Member

@joergsteffens joergsteffens commented Oct 21, 2025

Thank you for contributing to the Bareos Project!

This PR covers following topics:

  1. RPM install script output will be redirected to /var/log/bareos/<packagename>-install.log
  2. RPM install debug output can be enabled by export BAREOS_INSTALL_DEBUG=1
  3. ULC RPM packages use the same config handling as normal bareos-filedaemon packages (configtemplatedir and deploy_config)

Please check

  • Short description and the purpose of this PR is present above this paragraph
  • Your name is present in the AUTHORS file (optional)

If you have any questions or problems, please give a comment in the PR.

Helpful documentation and best practices

Checklist for the reviewer of the PR (will be processed by the Bareos team)

Make sure you check/merge the PR using devtools/pr-tool to have some simple automated checks run and a proper changelog record added.

General
  • Is the PR title usable as CHANGELOG entry?
  • Purpose of the PR is understood
  • Commit descriptions are understandable and well formatted
  • Required backport PRs have been created
  • Correct milestone is set
Source code quality
  • Source code changes are understandable
  • Variable and function names are meaningful
  • Code comments are correct (logically and spelling)
  • Required documentation changes are present and part of the PR
Manual Tests
  • Upgrade RPM ULC from 24.x on
    • RHEL 8
    • Mageia 9

@joergsteffens joergsteffens self-assigned this Oct 21, 2025
@joergsteffens joergsteffens added the requires no backport This will not be backported label Oct 21, 2025
@joergsteffens joergsteffens added this to the 25.0.0 milestone Oct 21, 2025
@joergsteffens joergsteffens force-pushed the dev/joergs/master/config-once-ulc branch from 12c9d23 to c958695 Compare October 22, 2025 10:56
@joergsteffens joergsteffens requested a review from arogge October 22, 2025 10:58
@joergsteffens joergsteffens marked this pull request as ready for review October 22, 2025 11:03
Copy link
Member

@arogge arogge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and manual tests worked correctly.

joergsteffens and others added 3 commits October 30, 2025 09:39
Redirect install scripts output to
/var/log/bareos/<packagename>-install.log

Setting
export BAREOS_INSTALL_DEBUG=1
before installation enables debug output.
... instead of using RPM config files
also for the Bareos Universal Linux Client (ULC) on RPM.
@BareosBot BareosBot force-pushed the dev/joergs/master/config-once-ulc branch from 8d3051c to 14ef226 Compare October 30, 2025 09:39
@BareosBot BareosBot merged commit ab91802 into master Oct 30, 2025
@BareosBot BareosBot deleted the dev/joergs/master/config-once-ulc branch October 30, 2025 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

requires no backport This will not be backported

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants