RPM: fix restarting bareos-fd on upgrades from bareos <= 24#2395
Merged
RPM: fix restarting bareos-fd on upgrades from bareos <= 24#2395
Conversation
a70f162 to
94562d3
Compare
arogge
approved these changes
Oct 17, 2025
Member
arogge
left a comment
There was a problem hiding this comment.
The only odd things I could identify are:
- RHEL 10 (at least in the repotest container) emits the message "warning: Unable to get systemd shutdown inhibition lock: Could not activate remote peer: activation request failed: unit is invalid." during upgrade, it seems this is not a problem though
- RPM will tell you that it moves your modified configuration files to
<xxx>.rpmsave, which is a bit weird given they will still be there after the upgrade.
As everything works correctly and it is a one-time operation for each installation, I'm happy with this.
On upgrade, the bareos-fd will be restarted (in %postun of the old package). When upgrading from Bareos < 25, we need a workaround to keep the existing configuration files. However, during the upgrade, some files get renamed (because we can't prevent RPM from doing so). We restore these files in %posttrans. As another workaround, we check if bareos-fd is running %pre. If yes, we will start it again in %postrans. This is only required for bareos-fd, as the other services don't got restarted.
37c4b18 to
075fd20
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for contributing to the Bareos Project!
On upgrade from Bareos <= 24 to Bareos >= 25 will fail to restart the bareos-fd properly, because this is done during %postun, while the config files only got restored in %postrans.
This PR creates a workaround for this.
Please check
If you have any questions or problems, please give a comment in the PR.
Helpful documentation and best practices
Checklist for the reviewer of the PR (will be processed by the Bareos team)
Make sure you check/merge the PR using
devtools/pr-toolto have some simple automated checks run and a proper changelog record added.General
Required backport PRs have been createdSource code quality
Tests