doc: don't alter configuration on package updates#2392
Merged
Conversation
13 tasks
522a3a8 to
e3ac54f
Compare
2df75b4 to
58e7acd
Compare
f2db0ae to
1a3a794
Compare
bruno-at-bareos
requested changes
Oct 16, 2025
Contributor
bruno-at-bareos
left a comment
There was a problem hiding this comment.
Great changes. See my comments.
| - :file:`/usr/lib/bareos/plugins/` | ||
| - :file:`/usr/local/lib/bareos/plugins/` | ||
| - :file:`/usr/local/bareos/lib/bareos/plugins/` | ||
| - :file:`$INSTDIR\\plugins\\` |
Contributor
There was a problem hiding this comment.
same as above
Suggested change
| - :file:`$INSTDIR\\plugins\\` | |
| - :file:`C:\\Program Files\\plugins\\` |
9c45b99 to
e3a285b
Compare
bruno-at-bareos
approved these changes
Oct 20, 2025
Contributor
bruno-at-bareos
left a comment
There was a problem hiding this comment.
Nice improvements, I have one pending request about the formatting of products names, but it is already acceptable.
| cp -a /tmp/bareos-dir.d /etc/bareos/ | ||
|
|
||
| Restart the |dir| and verify your configuration. Also make sure, that all resource configuration files coming from Bareos packages exists, in doubt as empty files, see :ref:`remove configuration resource files <section-deleteConfigurationResourceFiles>`. | ||
| Behavior |
Contributor
There was a problem hiding this comment.
Can we try to have component and package names in this section designed the same way ?
Suggested change
| Behavior | |
| * On upgrades, the existing configuration files for the components ``bareos-dir``, ``bareos-sd``, ``bareos-fd``, ``bconsole`` and ``bareos-traymonitor`` will not get modified. |
or use double asterisk like below ... because here the name is just italic. If this is what we want, then make it also for bareos-storage-tape bareos-storage.
Member
Author
There was a problem hiding this comment.
I chose different formatting more or less on purpose (or at least have been unsure, what to use). As we have a naming convention for packages (https://docs.bareos.org/DocumentationStyleGuide/SpecificFormatting.html#name) I changed all to that.
| However, they will only be used, when the legacy configuration file does not exist. | ||
|
|
||
| See :ref:`section-UpdateToConfigurationSubdirectories` for details and how to migrate to :ref:`section-SubdirectoryConfigurationScheme`. | ||
| As long as your configuration didn't show any deprecation warnings before the upgrade, |
Contributor
There was a problem hiding this comment.
Seems one line has escaped the changes ;-)
Suggested change
| As long as your configuration didn't show any deprecation warnings before the upgrade, |
Co-authored-by: Bruno Friedmann @bareos <89836284+bruno-at-bareos@users.noreply.github.com>
... as it is no clear, how to use them in a unified way.
to make table source more human readable and allow multi-line cells. Unfortenatly, the :width: parameter is ignored in our environment, to limit the table to the available width.
e3a285b to
d47666d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for contributing to the Bareos Project!
This PR contains the neccessary documentation change to #2338
Please check
If you have any questions or problems, please give a comment in the PR.
Helpful documentation and best practices
Checklist for the reviewer of the PR (will be processed by the Bareos team)
Make sure you check/merge the PR using
devtools/pr-toolto have some simple automated checks run and a proper changelog record added.General
Source code quality