grpc: fix extra / for directories#2373
Merged
BareosBot merged 12 commits intobareos:masterfrom Sep 29, 2025
Merged
Conversation
Its not well specified wether _both_ link _and_ fname should end in /, or if just link should end in /. The core mostly does it in a way where fname does _not_ end in /, but link does. I assumed that this was the rule, but it turns out that the plugins simply set fname _and_ link to the same path ending in /. This mismatch of assumption and reality meant that the grpc plugin now created paths with double / at the end, which tripped up the accurate information as well as the file listings. This commit fixes this by always stripping any trailing / from fname and always adding one trailing / to link (after stripping all the rest of them).
de9bb45 to
2c72dd8
Compare
3e72fb3 to
d54f24e
Compare
7 tasks
pstorz
requested changes
Sep 26, 2025
systemtests/tests/py3plug-fd-local-fileset-basic/testrunner-accurate
Outdated
Show resolved
Hide resolved
systemtests/tests/py3plug-fd-local-fileset-basic/testrunner-basic
Outdated
Show resolved
Hide resolved
d54f24e to
64f0050
Compare
pstorz
approved these changes
Sep 29, 2025
64f0050 to
7d6ca9c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for contributing to the Bareos Project!
The grpc plugin accidentally added an extra / at the end of directories which causes accurate to always pick up all directories.
This PR also includes
Please check
If you have any questions or problems, please give a comment in the PR.
Helpful documentation and best practices
Checklist for the reviewer of the PR (will be processed by the Bareos team)
Make sure you check/merge the PR using
devtools/pr-toolto have some simple automated checks run and a proper changelog record added.General
Source code quality
Tests