plugins: add proxmox backup#2372
Merged
BareosBot merged 70 commits intobareos:masterfrom Nov 17, 2025
Merged
Conversation
1111e93 to
5c1bffe
Compare
2582996 to
1fadfe6
Compare
arogge
requested changes
Oct 6, 2025
Member
arogge
left a comment
There was a problem hiding this comment.
I found quite a few things to complain about, sorry for that.
Haven't looked at the documentation yet.
systemtests/tests/py3plug-fd-vmware/python-modules/BareosFdPluginVMware.py
Outdated
Show resolved
Hide resolved
10e4a2e to
4db6ed0
Compare
7b93ea9 to
0f2959c
Compare
sebsura
requested changes
Nov 10, 2025
Contributor
sebsura
left a comment
There was a problem hiding this comment.
Looks pretty good. I found some small things. Please see below.
systemtests/tests/py3plug-fd-proxmox/etc/bareos/bareos-fd.d/client/myself.conf.in
Outdated
Show resolved
Hide resolved
systemtests/tests/py3plug-fd-proxmox/etc/bareos/bareos-dir.d/fileset/SelfTest.conf.in
Outdated
Show resolved
Hide resolved
8f3915f to
097ef5b
Compare
sebsura
requested changes
Nov 13, 2025
docs/manuals/source/TasksAndConcepts/Plugins/FileDaemonPlugins/ProxmoxPlugin.rst.inc
Outdated
Show resolved
Hide resolved
docs/manuals/source/TasksAndConcepts/Plugins/FileDaemonPlugins/ProxmoxPlugin.rst.inc
Show resolved
Hide resolved
docs/manuals/source/TasksAndConcepts/Plugins/FileDaemonPlugins/ProxmoxPlugin.rst.inc
Show resolved
Hide resolved
docs/manuals/source/TasksAndConcepts/Plugins/FileDaemonPlugins/ProxmoxPlugin.rst.inc
Outdated
Show resolved
Hide resolved
docs/manuals/source/TasksAndConcepts/Plugins/FileDaemonPlugins/ProxmoxPlugin.rst.inc
Show resolved
Hide resolved
docs/manuals/source/TasksAndConcepts/Plugins/FileDaemonPlugins/ProxmoxPlugin.rst.inc
Outdated
Show resolved
Hide resolved
docs/manuals/source/TasksAndConcepts/Plugins/FileDaemonPlugins/ProxmoxPlugin.rst.inc
Outdated
Show resolved
Hide resolved
sebsura
previously requested changes
Nov 13, 2025
Contributor
sebsura
left a comment
There was a problem hiding this comment.
Reviewed the code, its really good now, just want a few more debug messages in case things go wrong.
arogge
approved these changes
Nov 13, 2025
Member
arogge
left a comment
There was a problem hiding this comment.
As far as I can tell this is fine now, but I changed a lot of the code, so that's more than just a bit opinionated.
9f7a659 to
6b7dc1b
Compare
In sync with arogge the PR is ready.
3a947a5 to
2598b43
Compare
* avoid split/join * look at "Starting backup of" for type so we can fail cleanly on newly introduced types * get timestamp from "Backup started at" instead of datetime.now()
* create virtual file as PROXMOX/... instead of /var/lib/... so it cannot clash with regular files * allow setting the restore path using "restore_path" option * adapt systemtest
* switch backup/restore branch based on self.level * ignore restoretodisk on backup
* functions that should never be called throw NotImplementedError * add get_acl() / get_xattr() that return no data
Retrieve the maximum pipe size from /proc and increase LogPipe's pipe size to that.
set it in one location only, default ON if * ENABLE_PYTHON * Distribution == "debian" * Distribution version >= 12 otherwise OFF
This allows us to set cache variables in any of the subdirectories and then use these in BareosGenerateDebianInfo later. Also move the ENABLE_PROXMOX option next to the rest of the cmake proxmox things.
${rscripts} -> ${BAREOS_SCRIPTS_DIR}
Instead of failing silently, provide a message that the program was not found on start and status.
* check if process is alive before backing up data * wait for process to exit (and check return code) before finishing a backup or restore * close the restore process' stdin so it knows we're done restoring data
otherwise the core will create a bogus directory based on the virtual file name we are restoring.
* add force option to overwrite a VM/container on restore * support on/off yes/no 1/0 on boolean options * detect unknown extra options
* add comments with sample output * reorder to match the expected output order * move default guest names into parser
This makes the plugin adhere to ADR-0004.
Add more debug messages as suggested in code review.
As suggested in code-review enrich the ValueErrors on option assignment with the name of the option and the value passed.
pct restore requires --rootfs option to restore from stdin. For now the user has to provide this as a plugin option to Bareos.
cd1e5ee to
aebb95d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for contributing to the Bareos Project!
Please check
If you have any questions or problems, please give a comment in the PR.
TODO
Helpful documentation and best practices
Checklist for the reviewer of the PR (will be processed by the Bareos team)
Make sure you check/merge the PR using
devtools/pr-toolto have some simple automated checks run and a proper changelog record added.General
Required backport PRs have been createdSource code quality
Tests