Merged
Conversation
Because the decrement does not happen inside the lock, multiple threads can run into the "else" branch, which then causes a double free. The better solution would be for decrement to return the value after the decrement, but as this is not performance cricital, the easy fix is probably the better one
Because of the way this list is implemented, we need to make sure that we 1) never free an element still on the list, and 2) only remove elements that are _actually_ on the list. So to make it safe to free the element in this function, we first search for it in the list, and remove it if its on there.
This was referenced Sep 4, 2025
11dbc4d to
870a315
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because the decrement does not happen inside the lock, multiple threads can run into the "else" branch, which then causes a double free.
The better solution would be for decrement to return the value after the decrement, but as this is not performance cricital, the easy fix is probably the better one
fixes issue #2339.
Thank you for contributing to the Bareos Project!
Please check
If you have any questions or problems, please give a comment in the PR.
Helpful documentation and best practices
Checklist for the reviewer of the PR (will be processed by the Bareos team)
Make sure you check/merge the PR using
devtools/pr-toolto have some simple automated checks run and a proper changelog record added.General
Source code quality