systemtest: speed up always-incremental with sleep 0.25#2358
Merged
systemtest: speed up always-incremental with sleep 0.25#2358
Conversation
07a52f1 to
851009b
Compare
Member
|
Does it make sense to backport this? |
Contributor
Author
I would say yes for 24 as it is easy to apply the changes (previous changes have been backported to that version). #2366 created |
7 tasks
215d0d3 to
ca34dbb
Compare
Signed-off-by: Bruno Friedmann <bruno.friedmann@bareos.com>
We calculate a near future and use 'when=' expression to schedule both consolidation jobs at the same time. Additionally we uniform the log name replacing ':' by '_' like set in other tests Signed-off-by: Bruno Friedmann <bruno.friedmann@bareos.com>
58786b7 to
4865460
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR try to find the shortest interval for sleep in always-incremental systemtest, before having too much error on CI/CD.
The initial value of 2 secondes leads to no errors but then make tests quite long.
Thank you for contributing to the Bareos Project!
Please check
If you have any questions or problems, please give a comment in the PR.
Helpful documentation and best practices
Checklist for the reviewer of the PR (will be processed by the Bareos team)
Make sure you check/merge the PR using
devtools/pr-toolto have some simple automated checks run and a proper changelog record added.General
Source code quality