doc: storage backend add note about static build#2350
Merged
BareosBot merged 5 commits intobareos:masterfrom Aug 29, 2025
Merged
doc: storage backend add note about static build#2350BareosBot merged 5 commits intobareos:masterfrom
BareosBot merged 5 commits intobareos:masterfrom
Conversation
Add notice about validity only for HAVE_DYNAMIC_SD_BACKEND builded daemon and can't be used for statically builded like our Windows. Fix bareos/internal#396 Signed-off-by: Bruno Friedmann <bruno.friedmann@bareos.com>
sebsura
requested changes
Aug 27, 2025
Contributor
sebsura
left a comment
There was a problem hiding this comment.
Im not quite happy with the text as written. Let me know what you think of my suggestion.
...uals/source/manually_added_config_directive_descriptions/sd-storage-BackendDirectory.rst.inc
Outdated
Show resolved
Hide resolved
...uals/source/manually_added_config_directive_descriptions/sd-storage-BackendDirectory.rst.inc
Outdated
Show resolved
Hide resolved
Co-authored-by: Sebastian Sura <124262655+sebsura@users.noreply.github.com>
0d8dbe2 to
c2ebaf5
Compare
sebsura
requested changes
Aug 28, 2025
...uals/source/manually_added_config_directive_descriptions/sd-storage-BackendDirectory.rst.inc
Outdated
Show resolved
Hide resolved
...uals/source/manually_added_config_directive_descriptions/sd-storage-BackendDirectory.rst.inc
Show resolved
Hide resolved
Signed-off-by: Bruno Friedmann <bruno.friedmann@bareos.com>
Signed-off-by: Bruno Friedmann <bruno.friedmann@bareos.com>
f569f10 to
8503934
Compare
sebsura
approved these changes
Aug 29, 2025
Contributor
sebsura
left a comment
There was a problem hiding this comment.
Thanks for the great work!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add notice about validity only for
HAVE_DYNAMIC_SD_BACKENDbuildeddaemon and can't be used for statically builded like our Windows.
Fix bareos/internal#396
Thank you for contributing to the Bareos Project!
Please check
If you have any questions or problems, please give a comment in the PR.
Helpful documentation and best practices
Checklist for the reviewer of the PR (will be processed by the Bareos team)
Make sure you check/merge the PR using
devtools/pr-toolto have some simple automated checks run and a proper changelog record added.General
Required backport PRs have been createdSource code quality