Skip to content

packaging: add setcap/getcap requirements#2347

Merged
BareosBot merged 4 commits intobareos:masterfrom
bruno-at-bareos:dev/bruno/master/add-missing-requires-setcap-getcap
Sep 29, 2025
Merged

packaging: add setcap/getcap requirements#2347
BareosBot merged 4 commits intobareos:masterfrom
bruno-at-bareos:dev/bruno/master/add-missing-requires-setcap-getcap

Conversation

@bruno-at-bareos
Copy link
Contributor

@bruno-at-bareos bruno-at-bareos commented Aug 21, 2025

bareos-config-libs is used to add capabilities to binaries to be used
during tape encryption.

We add the requirements to bareos-config instead of
bareos-storage-tape package because we have all tools requirements
declared in this package.

fix bareos/internal#416

Thank you for contributing to the Bareos Project!

Please check

  • Short description and the purpose of this PR is present above this paragraph
  • Your name is present in the AUTHORS file (optional)

If you have any questions or problems, please give a comment in the PR.

Helpful documentation and best practices

Checklist for the reviewer of the PR (will be processed by the Bareos team)

Make sure you check/merge the PR using devtools/pr-tool to have some simple automated checks run and a proper changelog record added.

General
  • Is the PR title usable as CHANGELOG entry?
  • Purpose of the PR is understood
  • Commit descriptions are understandable and well formatted
  • Required backport PRs have been created
  • Correct milestone is set
Source code quality
  • Source code changes are understandable
  • Variable and function names are meaningful
  • Code comments are correct (logically and spelling)
  • Required documentation changes are present and part of the PR

@bruno-at-bareos bruno-at-bareos added this to the 25.0.0 milestone Aug 21, 2025
@bruno-at-bareos bruno-at-bareos added bugfix dependencies Pull requests that update a dependency file requires backport to 24 labels Aug 21, 2025
@bruno-at-bareos bruno-at-bareos self-assigned this Aug 21, 2025
@bruno-at-bareos bruno-at-bareos requested a review from arogge August 21, 2025 12:10
@bruno-at-bareos bruno-at-bareos force-pushed the dev/bruno/master/add-missing-requires-setcap-getcap branch from 40e6aaa to f96bd38 Compare August 25, 2025 09:25
@bruno-at-bareos
Copy link
Contributor Author

Might be a good candidate to resolve also #2348

Copy link
Member

@arogge arogge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you take a look at the comments I left?
Maybe it doesn't make sense to change this, but I still wanted to bring it up.

@bruno-at-bareos bruno-at-bareos force-pushed the dev/bruno/master/add-missing-requires-setcap-getcap branch 2 times, most recently from b976cf7 to 8db6e3e Compare September 10, 2025 09:38
@bruno-at-bareos
Copy link
Contributor Author

bruno-at-bareos commented Sep 15, 2025

backport in #2374

@bruno-at-bareos bruno-at-bareos force-pushed the dev/bruno/master/add-missing-requires-setcap-getcap branch from 8db6e3e to 255b202 Compare September 22, 2025 14:14
Copy link
Member

@arogge arogge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thank you!

bruno-at-bareos and others added 4 commits September 29, 2025 09:26
bareos-config-libs is used to add capabilities to binaries to be used
during tape encryption.

We add the requirements to ``bareos-config`` package instead of
``bareos-storage-tape`` package as we have all requirements declared
in this package.

use Requires: %{_sbindir}/getcap, setcap in spec.

fix bareos/internal#416

Signed-off-by: Bruno Friedmann <bruno.friedmann@bareos.com>
Fix bareos/issue/bareos#2348

In case of disaster tools should be able to extract data from volumes
without having to install a whole bareos-storage package.

plugin/autoxflate-sd.so
backend/libbareossd-file.so

are now packaged in bareos-common.

Signed-off-by: Bruno Friedmann <bruno.friedmann@bareos.com>
Recommends is known since Fedora 24 and supported on all os we build

Signed-off-by: Bruno Friedmann <bruno.friedmann@bareos.com>
@BareosBot BareosBot force-pushed the dev/bruno/master/add-missing-requires-setcap-getcap branch from 8600ab4 to 9759a71 Compare September 29, 2025 09:26
@BareosBot BareosBot merged commit ff05d6f into bareos:master Sep 29, 2025
@bruno-at-bareos bruno-at-bareos deleted the dev/bruno/master/add-missing-requires-setcap-getcap branch November 26, 2025 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file requires backport to 24

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bareos-tools package should have the file backend

3 participants