Skip to content

dird: fix nextvol crash#2335

Merged
BareosBot merged 9 commits intobareos:masterfrom
sebsura:dev/ssura/master/fix-nextvol-crash
Sep 16, 2025
Merged

dird: fix nextvol crash#2335
BareosBot merged 9 commits intobareos:masterfrom
sebsura:dev/ssura/master/fix-nextvol-crash

Conversation

@sebsura
Copy link
Contributor

@sebsura sebsura commented Aug 4, 2025

Thank you for contributing to the Bareos Project!

Currently list nextvol crashes if a job without a schedule was selected. This pr fixes this.

This pr also fixes some issues with our tests; in particular it fixes the rest of the restore test issues on windows.

Please check

  • Short description and the purpose of this PR is present above this paragraph
  • Your name is present in the AUTHORS file (optional)

If you have any questions or problems, please give a comment in the PR.

Helpful documentation and best practices

Checklist for the reviewer of the PR (will be processed by the Bareos team)

Make sure you check/merge the PR using devtools/pr-tool to have some simple automated checks run and a proper changelog record added.

General
  • Is the PR title usable as CHANGELOG entry?
  • Purpose of the PR is understood
  • Commit descriptions are understandable and well formatted
    Required backport PRs have been created
  • Correct milestone is set
Source code quality
  • Source code changes are understandable
  • Variable and function names are meaningful
  • Code comments are correct (logically and spelling)
  • Required documentation changes are present and part of the PR
Tests
  • Decision taken that a test is required (if not, then remove this paragraph)
  • The choice of the type of test (unit test or systemtest) is reasonable
  • Testname matches exactly what is being tested
  • On a fail, output of the test leads quickly to the origin of the fault

@sebsura sebsura requested a review from pstorz September 4, 2025 06:25
@sebsura sebsura force-pushed the dev/ssura/master/fix-nextvol-crash branch from 5267f19 to d14c510 Compare September 4, 2025 11:47
@sebsura sebsura added this to the 25.0.0 milestone Sep 4, 2025
@sebsura sebsura force-pushed the dev/ssura/master/fix-nextvol-crash branch 2 times, most recently from 4bada4b to 98602b8 Compare September 5, 2025 06:29
@sebsura sebsura force-pushed the dev/ssura/master/fix-nextvol-crash branch from fb33d35 to 094d8db Compare September 16, 2025 07:47
The problem occurs if the tests are reordered (by chance).  A lot of
tests changed the state that other tests depended upon.

E.g. the fileset test broke because inserting the hardlink fileset
changed the spacing.
@sebsura sebsura force-pushed the dev/ssura/master/fix-nextvol-crash branch from 094d8db to 0aa9959 Compare September 16, 2025 07:51
@sebsura sebsura added the bug This addresses a bug label Sep 16, 2025
@sebsura sebsura self-assigned this Sep 16, 2025
Also refactor how we call perl scripts so that they work even if the
path contains spaces.
@sebsura sebsura force-pushed the dev/ssura/master/fix-nextvol-crash branch from 0aa9959 to 6cda5e0 Compare September 16, 2025 09:34
@BareosBot BareosBot merged commit 592b4b9 into bareos:master Sep 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug This addresses a bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants