Merged
Conversation
367aef0 to
b7205fc
Compare
b7205fc to
7a0a189
Compare
38b32ea to
6970890
Compare
16ebc26 to
941ad80
Compare
Member
|
We should avoid the double-lock on batch-inserts, especially as the error retrieval we added a lock for doesn't work when batch-insert is used. |
arogge
requested changes
Sep 24, 2025
Member
arogge
left a comment
There was a problem hiding this comment.
Sorry, I have one final thing...
ca985c1 to
0667968
Compare
arogge
reviewed
Sep 25, 2025
d7ca667 to
5f73629
Compare
Member
|
Are you actually going to backport this down into 23? |
Most of the time the lock issue only results in bad error messages. Killing the bareos director for this is probably not the right idea. So for now its being downgraded to just being logged.
This test randomly generates commands and sends them to the director. This is done to make sure that commands do not crash the director for no reason.
This causes weird issues when StripPath is used as it is not able to properly strip paths not ending in `/` now. This may also solve other problems.
5f73629 to
53cdc75
Compare
Contributor
Author
|
No. The fixes are not applicable to 23. |
Previously we could leave the GetFileList() call without adding any files to the bsr. This would cause the bsr jobid to stay at 0 and AddVolumeInformationToBsr would then print a very cryptic error message (as it didnt know it should look for a specific jobid, but instead search for the (unset) job name). This fixes this by making sure we exit early if we detect that no file was inserted into the bsr.
Due to a missing % in the meta searched pattern, filer classification was incomplete. Signed-off-by: Bruno Friedmann <bruno.friedmann@bareos.com>
53cdc75 to
a5aa8f3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for contributing to the Bareos Project!
This pr fixes issue #2312. I added the missing locks and also removed the builtin crash from the ownership check. As the director going down is a pretty major issue, it should not happen if only some error messages get potentially misread.
This also fixes issue #2336 ...
We added also a fix for
subscriptionview to better classified filer units, reported by customer with support.Please check
If you have any questions or problems, please give a comment in the PR.
Helpful documentation and best practices
Checklist for the reviewer of the PR (will be processed by the Bareos team)
Make sure you check/merge the PR using
devtools/pr-toolto have some simple automated checks run and a proper changelog record added.General
Source code quality