Skip to content

systemtest: always incremental add one job with one removed file#2329

Merged
BareosBot merged 4 commits intobareos:masterfrom
bruno-at-bareos:dev/bruno/master/ai-systemtest-with-deleted-file
Aug 21, 2025
Merged

systemtest: always incremental add one job with one removed file#2329
BareosBot merged 4 commits intobareos:masterfrom
bruno-at-bareos:dev/bruno/master/ai-systemtest-with-deleted-file

Conversation

@bruno-at-bareos
Copy link
Contributor

@bruno-at-bareos bruno-at-bareos commented Jul 22, 2025 •
edited by sebsura
Loading

This PR aims to fix the fact that We don't test deleted files in AI test scenario, but only 2 time empty job.

We adjust the tests to also tests deleted files job with a result looking like
file 2 | size 0

The case mentioned in https://groups.google.com/u/0/g/bareos-users/c/NB4Z3uYGfuU then is fully covered.

  • systemtest: CMakefile fix typo and year copyright
  • systemtest: add one job with one removed file

Please check

  • Short description and the purpose of this PR is present above this paragraph
  • Your name is present in the AUTHORS file (optional)

If you have any questions or problems, please give a comment in the PR.

Helpful documentation and best practices

Checklist for the reviewer of the PR (will be processed by the Bareos team)

Make sure you check/merge the PR using devtools/pr-tool to have some simple automated checks run and a proper changelog record added.

General
  • Is the PR title usable as CHANGELOG entry?
  • Purpose of the PR is understood
  • Commit descriptions are understandable and well formatted
    Required backport PRs have been created
  • Correct milestone is set
Source code quality
  • Source code changes are understandable
  • Variable and function names are meaningful
  • Code comments are correct (logically and spelling)
  • Required documentation changes are present and part of the PR
Tests
  • Decision taken that a test is required (if not, then remove this paragraph)
  • The choice of the type of test (unit test or systemtest) is reasonable
  • Testname matches exactly what is being tested
  • On a fail, output of the test leads quickly to the origin of the fault

@bruno-at-bareos bruno-at-bareos changed the title dev/bruno/master/ai systemtest with deleted file systemtest: always incremental add one job with one removed file Jul 22, 2025
@bruno-at-bareos bruno-at-bareos requested a review from sebsura July 22, 2025 13:13
@bruno-at-bareos bruno-at-bareos self-assigned this Jul 22, 2025
@bruno-at-bareos bruno-at-bareos added this to the 25.0.0 milestone Jul 22, 2025
sebsura
sebsura requested changes Jul 23, 2025
View reviewed changes
@bruno-at-bareos bruno-at-bareos force-pushed the dev/bruno/master/ai-systemtest-with-deleted-file branch 3 times, most recently from 9926331 to b7101f2 Compare July 24, 2025 12:20
@bruno-at-bareos bruno-at-bareos requested a review from sebsura July 29, 2025 06:43
sebsura
sebsura requested changes Aug 4, 2025
View reviewed changes
@bruno-at-bareos
systemtest: CMakefile fix typo and year copyright
918c763 
Signed-off-by: Bruno Friedmann <bruno.friedmann@bareos.com>
@bruno-at-bareos
systemtest: add test with one removed file job
58f62c3 
- rename systemtests and add testrunner-05-consolidate-deleted-file
- Max Run Time = 10

Signed-off-by: Bruno Friedmann <bruno.friedmann@bareos.com>
@bruno-at-bareos
use .sql for checking file existence
64dec3f 
- Deleted files always have a fileindex of 0, where as non deleted
  files always have a fileindex > 0. We use .sql command to retrieve
  the information simpler than .bvfs_ commands.
- Add comments following review suggestions.
- Fix copyright range
@bruno-at-bareos bruno-at-bareos force-pushed the dev/bruno/master/ai-systemtest-with-deleted-file branch from b7101f2 to 64dec3f Compare August 12, 2025 08:32
sebsura
sebsura approved these changes Aug 19, 2025
View reviewed changes
Copy link
Contributor

@sebsura sebsura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the great work!

@BareosBot BareosBot merged commit 592dcff into bareos:master Aug 21, 2025
1 check was pending
@bruno-at-bareos bruno-at-bareos deleted the dev/bruno/master/ai-systemtest-with-deleted-file branch November 26, 2025 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sebsura sebsura sebsura approved these changes

Assignees

@bruno-at-bareos bruno-at-bareos

Labels

enhancement

Projects

None yet

Milestone

25.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@bruno-at-bareos @sebsura @BareosBot