Skip to content

truncate: fix return status bug#2300

Merged
BareosBot merged 5 commits intobareos:masterfrom
florian-at-bareos:dev/fburger/master/fix-admin-termination-status
Jul 8, 2025
Merged

truncate: fix return status bug#2300
BareosBot merged 5 commits intobareos:masterfrom
florian-at-bareos:dev/fburger/master/fix-admin-termination-status

Conversation

@florian-at-bareos
Copy link
Contributor

@florian-at-bareos florian-at-bareos commented Jun 16, 2025

Regardless of the sucess of truncating, the TruncateCmd returns "false".
The return status of this method states whether the console should stay alive after this command or not. since we always returned false, doing an admin job with truncate would always result in an admin error.

Fixes bareos/internal#242: admin job with truncate Error and Ok at the same time.

Thank you for contributing to the Bareos Project!

Please check

  • Short description and the purpose of this PR is present above this paragraph
  • Your name is present in the AUTHORS file (optional)

If you have any questions or problems, please give a comment in the PR.

Helpful documentation and best practices

Checklist for the reviewer of the PR (will be processed by the Bareos team)

Make sure you check/merge the PR using devtools/pr-tool to have some simple automated checks run and a proper changelog record added.

General
  • Is the PR title usable as CHANGELOG entry?
  • Purpose of the PR is understood
  • Commit descriptions are understandable and well formatted
  • Required backport PRs have been created
  • Correct milestone is set
Source code quality
  • Source code changes are understandable
  • Variable and function names are meaningful
  • Code comments are correct (logically and spelling)
  • Required documentation changes are present and part of the PR
Tests
  • Decision taken that a test is required (if not, then remove this paragraph)
  • The choice of the type of test (unit test or systemtest) is reasonable
  • Testname matches exactly what is being tested
  • On a fail, output of the test leads quickly to the origin of the fault

@florian-at-bareos florian-at-bareos self-assigned this Jun 16, 2025
@florian-at-bareos florian-at-bareos added the bug This addresses a bug label Jun 16, 2025
@florian-at-bareos florian-at-bareos added this to the 25.0.0 milestone Jun 16, 2025
@florian-at-bareos florian-at-bareos marked this pull request as ready for review June 18, 2025 08:28
@sebsura sebsura self-requested a review June 23, 2025 09:13
Copy link
Contributor

@sebsura sebsura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great find!

@arogge arogge force-pushed the dev/fburger/master/fix-admin-termination-status branch from de4bab3 to b7b0b78 Compare July 8, 2025 13:51
@BareosBot BareosBot merged commit fbb50c2 into bareos:master Jul 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants