Skip to content

plugins: introduce windows disaster recovery imager (barri)#2285

Merged
BareosBot merged 14 commits intobareos:masterfrom
sebsura:dev/ssura/master/windows-dr
Nov 14, 2025
Merged

plugins: introduce windows disaster recovery imager (barri)#2285
BareosBot merged 14 commits intobareos:masterfrom
sebsura:dev/ssura/master/windows-dr

Conversation

@sebsura
Copy link
Contributor

@sebsura sebsura commented May 27, 2025 •
edited by pstorz
Loading

Thank you for contributing to the Bareos Project!

Please check

  • Short description and the purpose of this PR is present above this paragraph
  • Your name is present in the AUTHORS file (optional)

If you have any questions or problems, please give a comment in the PR.

Helpful documentation and best practices

Checklist for the reviewer of the PR (will be processed by the Bareos team)

Make sure you check/merge the PR using devtools/pr-tool to have some simple automated checks run and a proper changelog record added.

General
  • Is the PR title usable as CHANGELOG entry?
  • Purpose of the PR is understood
  • Commit descriptions are understandable and well formatted
  • Required backport PRs have been created
  • Correct milestone is set
  • CD PR merged
Source code quality
  • Source code changes are understandable
  • Variable and function names are meaningful
  • Code comments are correct (logically and spelling)
  • Required documentation changes are present and part of the PR
Tests
  • Decision taken that a test is required (if not, then remove this paragraph)
  • The choice of the type of test (unit test or systemtest) is reasonable
  • Testname matches exactly what is being tested
  • On a fail, output of the test leads quickly to the origin of the fault

@sebsura sebsura added this to the 25.0.0 milestone May 27, 2025
@sebsura sebsura force-pushed the dev/ssura/master/windows-dr branch 2 times, most recently from b005002 to c5595e8 Compare May 28, 2025 06:47
@sebsura sebsura force-pushed the dev/ssura/master/windows-dr branch 2 times, most recently from 9329cdf to 173832a Compare June 5, 2025 06:02
@sebsura
Copy link
Contributor Author

sebsura commented Jun 5, 2025 •
edited
Loading

for standalone tool:

  • progress report

@sebsura sebsura force-pushed the dev/ssura/master/windows-dr branch from 173832a to 7e020f5 Compare June 6, 2025 09:28
@sebsura
Copy link
Contributor Author

sebsura commented Jun 23, 2025 •
edited
Loading

  • enhance error messages; especially for asserts.

@sebsura sebsura self-assigned this Jun 24, 2025
@sebsura sebsura force-pushed the dev/ssura/master/windows-dr branch 2 times, most recently from bf6fa95 to e32abb4 Compare June 27, 2025 07:32
@sebsura sebsura force-pushed the dev/ssura/master/windows-dr branch 2 times, most recently from 5fc6603 to 3b10930 Compare July 9, 2025 12:15
@sebsura sebsura force-pushed the dev/ssura/master/windows-dr branch 2 times, most recently from 62ae0be to 37f83ed Compare July 21, 2025 13:15
@sebsura
Copy link
Contributor Author

sebsura commented Aug 8, 2025 •
edited
Loading

  • dont put volumes/disks into the snapshot that dont get saved.

@sebsura sebsura force-pushed the dev/ssura/master/windows-dr branch from 9fd7d58 to bf5b616 Compare September 1, 2025 07:28
@sebsura sebsura force-pushed the dev/ssura/master/windows-dr branch from 527eba6 to 8aef26d Compare September 8, 2025 11:52
@pstorz pstorz force-pushed the dev/ssura/master/windows-dr branch from b2c7727 to c202ead Compare September 10, 2025 07:29
@sebsura sebsura force-pushed the dev/ssura/master/windows-dr branch 4 times, most recently from 7526830 to e0d3d70 Compare September 12, 2025 09:11
@arogge arogge requested a review from pstorz September 15, 2025 09:16
pstorz
pstorz requested changes Sep 29, 2025
View reviewed changes
Copy link
Member

@pstorz pstorz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work! Thank you very much.

Please see comments.

core/src/plugins/filed/windows_dr/restore_win.cc
},
};

// logger_->Trace("creating disk");
Copy link
Member

@pstorz pstorz Sep 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this comment go?

pstorz
pstorz requested changes Sep 29, 2025
View reviewed changes
Copy link
Member

@pstorz pstorz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work! Thank you very much.

Please see comments.

pstorz
pstorz previously requested changes Sep 30, 2025
View reviewed changes
@pstorz pstorz force-pushed the dev/ssura/master/windows-dr branch from d725ebc to d691cd7 Compare October 1, 2025 08:51
sebsura
sebsura commented Nov 5, 2025
View reviewed changes
@sebsura sebsura force-pushed the dev/ssura/master/windows-dr branch 3 times, most recently from 6e960d5 to fcb4dd7 Compare November 12, 2025 11:57
@pstorz pstorz force-pushed the dev/ssura/master/windows-dr branch 2 times, most recently from d845c1a to e349570 Compare November 13, 2025 12:02
@sebsura sebsura force-pushed the dev/ssura/master/windows-dr branch 2 times, most recently from 4ee8f8b to 9b2aec4 Compare November 13, 2025 13:52
@pstorz pstorz changed the title add windows disaster recovery plugin plugins: introduce windows disaster recovery plugin Nov 13, 2025
@pstorz pstorz changed the title plugins: introduce windows disaster recovery plugin plugins: introduce windows disaster recovery imager (barri) Nov 14, 2025
@pstorz pstorz dismissed their stale review November 14, 2025 09:33

Dismissed

@pstorz pstorz self-requested a review November 14, 2025 09:33
sebsura and others added 14 commits November 14, 2025 13:28
@sebsura @BareosBot
core: small fixes
4baa196
@sebsura @BareosBot
edit: make add_commas accept a const string
74c684d
@sebsura @BareosBot
filed: add comment explaining member
18ffe7a
@sebsura @BareosBot
grpc: fix small issues
e908abf 
These functions should be constexpr, and _ is a bad name!
@sebsura @BareosBot
bconsole-basic: disable test if it cannot be executed
e3d0d48
@sebsura @BareosBot
scheduler-test: make test less likely to fail
355c86f 
As SystemTime() only has second-precision, end - start may actually
eqaul 0 even though we waited one second if you are really unlucky.

After waiting two seconds it is basically guaranteed that time() also
advanced at least one second so this should never fail again.
@sebsura @BareosBot
barri: implement windows disaster recovery plugin
31377e9
@sebsura @BareosBot
tests: add unit test for the barri file format
34b062a
@sebsura @BareosBot
docs: add barri docs
23b1556
@pstorz @BareosBot
packaging: add barri packaging
4ef7dc3
@pstorz @BareosBot
barri plugin prefix: @barri@/ -> @BARRI/
e939118
@sebsura @BareosBot
fd-plugins: always consider plugin data as portable
f0e1d39 
Also fixes the issue where one plugin can stop the sending of events
to another plugin!
@pstorz @BareosBot
nsi: add missing SectionEnd
0576690
@BareosBot
Update CHANGELOG.md
1210898
@BareosBot BareosBot force-pushed the dev/ssura/master/windows-dr branch from 23d13af to 1210898 Compare November 14, 2025 13:28
@BareosBot BareosBot merged commit e4087f3 into bareos:master Nov 14, 2025
@sebsura sebsura linked an issue Nov 27, 2025 that may be closed by this pull request
plugin api does not distribute events to all plugins #2367
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@arogge arogge arogge left review comments

@pstorz pstorz pstorz approved these changes

Assignees

@sebsura sebsura

Labels

enhancement subscription

Projects

None yet

Milestone

25.0.0

Development

Successfully merging this pull request may close these issues.

plugin api does not distribute events to all plugins

4 participants

@sebsura @pstorz @arogge @BareosBot