Merged
Conversation
78b3fc0 to
b373fec
Compare
sebsura
requested changes
Jun 4, 2025
such that it uses the SqlQuery method with SqlDiscardResult. Also move main method its own file.
bac0247 to
7bbff9a
Compare
ae37904 to
52c9d5e
Compare
52c9d5e to
5053693
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue occuring when you run a RunScript bconsole command from a job. The produced output from that bconsole command is inserted in the database joblog, hence performs a database query (insert). Its query result would then override the existing query result which produces wrong behaviour if the existing query result was not entirely processed at this point.
This PR creates a new method for database queries that does not store the query result hence does not override anything. We use this method for adding lines to the database joblog.
Fixes bareos/internal#238: admin job only prints first line of list result
Fixes bareos/internal#342: Provide resultset-less DB query function
Thank you for contributing to the Bareos Project!
Please check
If you have any questions or problems, please give a comment in the PR.
Helpful documentation and best practices
Checklist for the reviewer of the PR (will be processed by the Bareos team)
Make sure you check/merge the PR using
devtools/pr-toolto have some simple automated checks run and a proper changelog record added.General
Required backport PRs have been createdSource code quality
Tests