Skip to content

fix admin job issues#2283

Merged
BareosBot merged 13 commits intobareos:masterfrom
florian-at-bareos:dev/fburger/master/fix-admin-job-issues
Jul 7, 2025
Merged

fix admin job issues#2283
BareosBot merged 13 commits intobareos:masterfrom
florian-at-bareos:dev/fburger/master/fix-admin-job-issues

Conversation

@florian-at-bareos
Copy link
Contributor

@florian-at-bareos florian-at-bareos commented May 23, 2025

This PR fixes an issue occuring when you run a RunScript bconsole command from a job. The produced output from that bconsole command is inserted in the database joblog, hence performs a database query (insert). Its query result would then override the existing query result which produces wrong behaviour if the existing query result was not entirely processed at this point.

This PR creates a new method for database queries that does not store the query result hence does not override anything. We use this method for adding lines to the database joblog.

Fixes bareos/internal#238: admin job only prints first line of list result
Fixes bareos/internal#342: Provide resultset-less DB query function

Thank you for contributing to the Bareos Project!

Please check

  • Short description and the purpose of this PR is present above this paragraph
  • Your name is present in the AUTHORS file (optional)

If you have any questions or problems, please give a comment in the PR.

Helpful documentation and best practices

Checklist for the reviewer of the PR (will be processed by the Bareos team)

Make sure you check/merge the PR using devtools/pr-tool to have some simple automated checks run and a proper changelog record added.

General
  • Is the PR title usable as CHANGELOG entry?
  • Purpose of the PR is understood
  • Commit descriptions are understandable and well formatted
    Required backport PRs have been created
  • Correct milestone is set
Source code quality
  • Source code changes are understandable
  • Variable and function names are meaningful
  • Code comments are correct (logically and spelling)
  • Required documentation changes are present and part of the PR
Tests
  • Decision taken that a test is required (if not, then remove this paragraph)
  • The choice of the type of test (unit test or systemtest) is reasonable
  • Testname matches exactly what is being tested
  • On a fail, output of the test leads quickly to the origin of the fault

@florian-at-bareos florian-at-bareos added this to the 25.0.0 milestone May 23, 2025
@florian-at-bareos florian-at-bareos self-assigned this May 23, 2025
@florian-at-bareos florian-at-bareos added the bug This addresses a bug label May 23, 2025
@florian-at-bareos florian-at-bareos force-pushed the dev/fburger/master/fix-admin-job-issues branch from 78b3fc0 to b373fec Compare May 26, 2025 08:40
@florian-at-bareos florian-at-bareos marked this pull request as ready for review May 26, 2025 12:25
@arogge arogge requested a review from sebsura June 3, 2025 09:59
@sebsura sebsura force-pushed the dev/fburger/master/fix-admin-job-issues branch from bac0247 to 7bbff9a Compare June 23, 2025 10:51
@sebsura sebsura force-pushed the dev/fburger/master/fix-admin-job-issues branch 2 times, most recently from ae37904 to 52c9d5e Compare June 24, 2025 06:01
@sebsura sebsura force-pushed the dev/fburger/master/fix-admin-job-issues branch from 52c9d5e to 5053693 Compare July 2, 2025 12:58
Copy link
Contributor

@sebsura sebsura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great Work!

@BareosBot BareosBot merged commit 40d985e into bareos:master Jul 7, 2025
1 check was pending
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug This addresses a bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants