postgresql: require non-ssl connection#2272
Merged
BareosBot merged 6 commits intobareos:masterfrom May 23, 2025
Merged
Conversation
sebsura
requested changes
May 14, 2025
33eae6d to
a8ca2fb
Compare
sebsura
requested changes
May 21, 2025
sebsura
approved these changes
May 23, 2025
Fixes bareos#1965: PostgreSQL with SSL fails in strange ways
replace PQconnectdb with PQconnectdbParams
f1b9735 to
cc81282
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since Postgresql connections with ssl enabled cause problems, we now require the connection to the server to be no ssl connection, see #1965.
Fixes #1965: PostgreSQL with SSL fails in strange ways
Note that if the postgresql server requires a ssl connection, connecting to this server using BareosDbPostgresql will always fail.
Thank you for contributing to the Bareos Project!
Please check
If you have any questions or problems, please give a comment in the PR.
Helpful documentation and best practices
Checklist for the reviewer of the PR (will be processed by the Bareos team)
Make sure you check/merge the PR using
devtools/pr-toolto have some simple automated checks run and a proper changelog record added.General
Required backport PRs have been createdSource code quality