Merged
Conversation
14914cc to
f2bceb6
Compare
f2bceb6 to
5913089
Compare
912772f to
b9174bf
Compare
florian-at-bareos
approved these changes
May 22, 2025
Contributor
florian-at-bareos
left a comment
There was a problem hiding this comment.
looks good, nice work!
01c7337 to
56672b3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently when creating a new file/directory in
/etc/bareos, it will have its group set to the primary-group of the user that created the file (in case of user "root", that is usually "root").As a result Bareos might be unable to read the new file.
This is especially true if you
cp somefile.conf newfile.confas the default files have all bits for other cleared (i.e. 0640), but would also impose a problem when you have an umask that denies read-access to other (i.e. 0026).If
/etc/bareosand its children had the setgid bit set, creating new files/directories would inherit the group from the directory and all new files would have their group set to "bareos" automatically.This PR aims to setgid for configdir
-
drwxr-sr-x 5 bareos wheel 512B May 20 08:05 /usr/local/etc/bareosdo we want 0750 -> we keep it like this (for traymonitor)- [X] fix /usr/local/etc/bareos/bconsole.conf from 0644 -> 0640
windowsChangelog as Breaking changesThank you for contributing to the Bareos Project!
Please check
If you have any questions or problems, please give a comment in the PR.
Helpful documentation and best practices
Checklist for the reviewer of the PR (will be processed by the Bareos team)
Make sure you check/merge the PR using
devtools/pr-toolto have some simple automated checks run and a proper changelog record added.General
Source code quality