Skip to content

mtx-changer: make mandatory test mt-st versus cpio-mt#2256

Merged
BareosBot merged 2 commits intobareos:masterfrom
bruno-at-bareos:dev/bruno/master/fix-internal-322-mt-cpio
May 14, 2025
Merged

mtx-changer: make mandatory test mt-st versus cpio-mt#2256
BareosBot merged 2 commits intobareos:masterfrom
bruno-at-bareos:dev/bruno/master/fix-internal-322-mt-cpio

Conversation

@bruno-at-bareos
Copy link
Contributor

@bruno-at-bareos bruno-at-bareos commented Apr 23, 2025

mt-st is no more a default for numerous Linux distributions,
we want to check which mt version is in used on all Linux
platform.

Fix internal issue bareos/internal#322

Thank you for contributing to the Bareos Project!

Please check

  • Short description and the purpose of this PR is present above this paragraph
  • Your name is present in the AUTHORS file (optional)

If you have any questions or problems, please give a comment in the PR.

Helpful documentation and best practices

Checklist for the reviewer of the PR (will be processed by the Bareos team)

Make sure you check/merge the PR using devtools/pr-tool to have some simple automated checks run and a proper changelog record added.

General
  • Is the PR title usable as CHANGELOG entry?
  • Purpose of the PR is understood
  • Commit descriptions are understandable and well formatted
  • Required backport PRs have been created
  • Correct milestone is set
Source code quality
  • Source code changes are understandable
  • Variable and function names are meaningful
  • Code comments are correct (logically and spelling)
  • Required documentation changes are present and part of the PR

@bruno-at-bareos bruno-at-bareos self-assigned this Apr 23, 2025
@bruno-at-bareos bruno-at-bareos added the bug This addresses a bug label Apr 23, 2025
@bruno-at-bareos bruno-at-bareos added this to the 25.0.0 milestone Apr 23, 2025
@arogge arogge self-requested a review April 28, 2025 09:24
Copy link
Member

@arogge arogge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the comment-block above the case is not really correct anymore. Maybe you could shorten/rewrite that.

Other than that I think it is fine.

@bruno-at-bareos bruno-at-bareos force-pushed the dev/bruno/master/fix-internal-322-mt-cpio branch from e03daa9 to 4a380cd Compare April 30, 2025 08:08
@bruno-at-bareos bruno-at-bareos requested a review from arogge April 30, 2025 08:12
Copy link
Member

@arogge arogge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thank you!

bruno-at-bareos and others added 2 commits May 14, 2025 11:31
mt-st is no more a default for numerous Linux distributions,
we want to check which mt version is in used on all Linux
platform. Adapt comment for Linux accordingly.

Fix internal issue bareos#322

Signed-off-by: Bruno Friedmann <bruno.friedmann@bareos.com>
@BareosBot BareosBot force-pushed the dev/bruno/master/fix-internal-322-mt-cpio branch from 1636192 to d076a04 Compare May 14, 2025 11:31
@BareosBot BareosBot merged commit a945aff into bareos:master May 14, 2025
@bruno-at-bareos bruno-at-bareos deleted the dev/bruno/master/fix-internal-322-mt-cpio branch November 26, 2025 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug This addresses a bug requires backport to 24

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants