cli-test: fix test on freebsd#2241
Merged
BareosBot merged 3 commits intobareos:masterfrom Apr 9, 2025
Merged
Conversation
6834069 to
2c34f31
Compare
Contributor
Author
|
Question: Should a volume changed checkpoint also reset the timed checkpoint timer ? |
Member
I think so, but I'll approve the PR now and see that it is merged soon :) |
It only makes sense to start the checkpoint interval once we have reserved the drive, as doing a checkpoint when no data was ever written; or when data was just first written to disk, does not make sense. This commit restarts the checkpoint timer if we use jit reservation to reserve a drive. This only happens once per backup job, so it cannot stall the timed checkpoint indefinitely.
d7476bd to
23826e8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pr fixes issues bareos/internal#316 and bareos/internal#307
Thank you for contributing to the Bareos Project!
Please check
If you have any questions or problems, please give a comment in the PR.
Helpful documentation and best practices
Checklist for the reviewer of the PR (will be processed by the Bareos team)
Make sure you check/merge the PR using
devtools/pr-toolto have some simple automated checks run and a proper changelog record added.General
Source code quality