dplcompat: fix unsupported size-suffixes on chunksize#2240
Merged
BareosBot merged 9 commits intobareos:masterfrom Jun 10, 2025
Merged
dplcompat: fix unsupported size-suffixes on chunksize#2240BareosBot merged 9 commits intobareos:masterfrom
BareosBot merged 9 commits intobareos:masterfrom
Conversation
sebsura
requested changes
Apr 8, 2025
fcd2a02 to
a861cf7
Compare
039f02f to
5e36362
Compare
672cd9e to
9460954
Compare
sebsura
requested changes
May 21, 2025
arogge
commented
May 26, 2025
45103ca to
1a96a67
Compare
sebsura
approved these changes
Jun 4, 2025
| fmt::format("value '{}' for option '{}' would be truncated: {}\n", | ||
| fmt::format(FMT_STRING("invalid argument '{}' for option '{}': {}\n"), | ||
| value, key, e.what())); | ||
| } catch (std::out_of_range& e) { |
Contributor
There was a problem hiding this comment.
This doesnt really matter, but feel free to 'fix' it anyways:
Suggested change
| } catch (std::out_of_range& e) { | |
| } catch (const std::out_of_range& e) { |
(same for the other exceptions).
This changes debugging at crud_storage's trace level (130) will now log the output of the program the stat operation is run. This also slightly improves some other trace information.
with this patch trailing characters after a number will be detected when parsion the device options string
the droplet backend supports bytesize suffixes (i.e. k,kb,m,mb,etc.) on most options. These suffixes were previously ignored by dplcompat and are currently reported as trailing junk. This adds support for honoring these suffixes to the chunksize option.
* enforce fmt compile-time checks * requires non-header-only fmt usage * add Dfmt() to format messages with fmt
For proper builds, CPM packages need the same CMAKE_BUILD_TYPE as the main build. As coverage forces CMAKE_BUILD_TYPE=Debug, we need to do this before including BareosCpmPackages.
only format the message if debug_level is high enough that d_msg() would emit a message.
cae0061 to
ab7746d
Compare
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for size-suffixes to chunksize parameter to be more compatible with the droplet backend.
This will now also detect trailing junk after numbers and changes debugging at crud_storage's trace level (130) will now log the output of the program the stat operation is run. This also slightly improves some other trace information.
Thank you for contributing to the Bareos Project!
Please check
If you have any questions or problems, please give a comment in the PR.
Helpful documentation and best practices
Checklist for the reviewer of the PR (will be processed by the Bareos team)
Make sure you check/merge the PR using
devtools/pr-toolto have some simple automated checks run and a proper changelog record added.General
Source code quality