cmake: fix not including BareosTargetTools in systemtests, needed for get_target_output_dir#2232
Merged
BareosBot merged 2 commits intobareos:masterfrom Mar 31, 2025
Conversation
Merged
7 tasks
sebsura
approved these changes
Mar 31, 2025
Contributor
|
Thanks for your work! |
f0678f1 to
34fb716
Compare
systemtests need it for get_target_output_dir in systemtests/cmake/BareosSystemtestFunctions.cmake. Only needed if GTest is not available, otherwise provided via core/src/tests/CMakeLists.txt. Also needed for branch bareoos-24. Fixes bareos#2231
34fb716 to
f6a68f9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
in systemtests/cmake/BareosSystemtestFunctions.cmake.
Only needed if GTest is not available, otherwise provided via core/src/tests/CMakeLists.txt.
Also needed for branch bareos-24.
Fixes #2231
Trivial change, no need to mention me in AUTHORS.
Thank you for contributing to the Bareos Project!
Please check
Your name is present in the AUTHORS file (optional)If you have any questions or problems, please give a comment in the PR.
Helpful documentation and best practices
Checklist for the reviewer of the PR (will be processed by the Bareos team)
Make sure you check/merge the PR using
devtools/pr-toolto have some simple automated checks run and a proper changelog record added.General
Source code quality