VMware Plugin: Fix for virtual USB devices#2213
Merged
BareosBot merged 6 commits intobareos:masterfrom Jun 3, 2025
Merged
Conversation
Member
Author
|
Note: The issue discussed in #2118 is not related to the changes for handling virtual USB devices. However, changes to handle empty changeId were added to this PR. |
6 tasks
78b22b6 to
b676e3b
Compare
The Plugin can now save and recreate VMs with VirtualUSB devices. Note that VirtualUSB devices could disappear when powering on the VM and the USB device is attached to a different running VM, so a warning message will be emitted when such devices are involved.
Currently backing up templates is not possible, because creating a snapshot of a template is not supported. This fix detects if trying to backup a template and fails the job with an appropriate error message.
Added status information about VirtualUSB devices. Also added limitation note about backup of templates currently not possible.
The plugin now checks if it could successfully retreive the CBT changeId from the restoreobject and fail the job otherwise.
Under rare circumstances it can happen that the changeId in the backing information of a snapshotted virtual disk is empty. This should normally not happen, as it makes subsequent incrementals impossible. Such an empty changeId is now handled appropriately so that a warning is emitted if it is empty and when incrementals are attempted the error message was adapted so that the helper script from contrib/misc/reschedule_job_as_full can be used to automatically trigger a full level job in that case.
fb3c422 to
9ba8306
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Plugin can now save and recreate VMs with VirtualUSB devices. Note that VirtualUSB devices could disappear when powering on the VM and the USB device is attached to a different running VM, so a warning message will be emitted when such devices are involved.
Additionally, the plugin now detects if attempting to backup a template and emits an appropriate error message in that case, as this is currently not possible.
Please check
If you have any questions or problems, please give a comment in the PR.
Helpful documentation and best practices
Checklist for the reviewer of the PR (will be processed by the Bareos team)
Make sure you check/merge the PR using
devtools/pr-toolto have some simple automated checks run and a proper changelog record added.General
Source code quality