webui: use WEB_UI path in apache bareos-webui.conf file#2201
Merged
BareosBot merged 3 commits intobareos:masterfrom Mar 24, 2025
Nico54g:patch-1
Merged
webui: use WEB_UI path in apache bareos-webui.conf file#2201BareosBot merged 3 commits intobareos:masterfrom Nico54g:patch-1
BareosBot merged 3 commits intobareos:masterfrom
Nico54g:patch-1
Conversation
- create `bareos-webui.conf.in` and set cmake variables - untrack and delete generated `baros-webui.conf` - add generated `bareos-webui.conf` to `.gitignore` - redo align to 4 spaces
- add `bareos-webui.conf.in` - update coypright year
bruno-at-bareos
approved these changes
Mar 24, 2025
Contributor
bruno-at-bareos
left a comment
There was a problem hiding this comment.
Thanks a lot for the proposal.
Accepted as tested and reviewed
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When i compile a new version of Bareos, the webui don't start because the path of installed webui doesn't respect the CMAKE_INSTALL_DIR which is absent in apache configuration file
bareos-webui.conf.This PR propose to have the file modified by cmake
lignes added in the file : webui/CMakeLists.txt
file webui/install/apache/bareos-webui.conf renamed bareos-webui.conf.in
and modified :
Thank you for contributing to the Bareos Project!
Please check
Your name is present in the AUTHORS file (optional)If you have any questions or problems, please give a comment in the PR.
Helpful documentation and best practices
Checklist for the reviewer of the PR (will be processed by the Bareos team)
Make sure you check/merge the PR using
devtools/pr-toolto have some simple automated checks run and a proper changelog record added.General
Source code quality