webui: use TemporaryDir as userdatadir in Selenium test#2194
Merged
BareosBot merged 3 commits intobareos:masterfrom Feb 27, 2025
Merged
webui: use TemporaryDir as userdatadir in Selenium test#2194BareosBot merged 3 commits intobareos:masterfrom
BareosBot merged 3 commits intobareos:masterfrom
Conversation
04d6fe1 to
fb2e2bd
Compare
arogge
approved these changes
Feb 27, 2025
Member
arogge
left a comment
There was a problem hiding this comment.
Looks good to me.
I'd say we need to backport it down to at least 23, but let's merge it immediately and then take care of the backports.
This was referenced Feb 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoid race-conditions with multiple scripts runs at the same time.
Please check
If you have any questions or problems, please give a comment in the PR.
Helpful documentation and best practices
Checklist for the reviewer of the PR (will be processed by the Bareos team)
Make sure you check/merge the PR using
devtools/pr-toolto have some simple automated checks run and a proper changelog record added.General
Required backport PRs have been createdCorrect milestone is set