Skip to content

increase accepted warnings for windows#2191

Merged
arogge merged 2 commits intobareos:masterfrom
arogge:loosen-win-quality-gate
Feb 26, 2025
Merged

increase accepted warnings for windows#2191
arogge merged 2 commits intobareos:masterfrom
arogge:loosen-win-quality-gate

Conversation

@arogge
Copy link
Member

@arogge arogge commented Feb 26, 2025

as this is not currently being worked on and changes tend to break this, we increase the limit to 2000 warnings.

Thank you for contributing to the Bareos Project!

Please check

  • Short description and the purpose of this PR is present above this paragraph
  • Your name is present in the AUTHORS file (optional)

If you have any questions or problems, please give a comment in the PR.

Helpful documentation and best practices

Checklist for the reviewer of the PR (will be processed by the Bareos team)

Make sure you check/merge the PR using devtools/pr-tool to have some simple automated checks run and a proper changelog record added.

General
  • Is the PR title usable as CHANGELOG entry?
  • Purpose of the PR is understood
  • Commit descriptions are understandable and well formatted
  • Required backport PRs have been created
  • Correct milestone is set
Source code quality
  • Source code changes are understandable
  • Variable and function names are meaningful
  • Code comments are correct (logically and spelling)
  • Required documentation changes are present and part of the PR
Tests
  • Decision taken that a test is required (if not, then remove this paragraph)
  • The choice of the type of test (unit test or systemtest) is reasonable
  • Testname matches exactly what is being tested
  • On a fail, output of the test leads quickly to the origin of the fault

as this is not currently being worked on and changes tend to break
this, we increase the limit to 2000 warnings.
@arogge arogge merged commit 3b0dd3c into bareos:master Feb 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants